[Bug 7505] New: build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

            Bug ID: 7505
           Summary: build/mkupdates/listpromotable deprecated goto
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: sysadmins
          Assignee: sysadmins@spamassassin.apache.org
          Reporter: davej@apache.org
  Target Milestone: Undefined

The daily rules promotion script, build/mkupdates/run_nightly, has the
following error in the listpromotable script:

+ promote_active_rules
+ pwd
+ /usr/bin/perl build/mkupdates/listpromotable
/usr/local/spamassassin/automc/svn/trunk
HTTP get: http://ruleqa.spamassassin.org/1-days-ago?xml=1
Use of "goto" to jump into a construct is deprecated at
build/mkupdates/listpromotable line 85.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

--- Comment #2 from Karsten Bräckelmann <gu...@rudersport.de> ---
Created attachment 5597
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5597&action=edit
Use "redo" instead of deprecated "goto" (jumping into a construct) to restart
the current foreach iteration.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

--- Comment #4 from Dave Jones <da...@apache.org> ---
I don't know of any way to test this without committing to production and
waiting to see how the next run goes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

Dave Jones <da...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davej@apache.org

--- Comment #1 from Dave Jones <da...@apache.org> ---
This one is over my head since I don't have a lot of experience with perl.  I
think the goto needs to be replaced with function calls but not sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org

--- Comment #5 from Kevin A. McGrail <km...@apache.org> ---
OK, then please hold off until after the release of 3.4.2 so we know everything
is good for that if you don't mind?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

--- Comment #6 from Dave Jones <da...@apache.org> ---
What is your version of perl?  I am still running CentOS 6 so it's v5.14.1.

Can you show what the command is in the spamfilter-check-config.sh so I can see
the whole line with arguments?  I would like to run the same command on my
server to see if that makes a difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |apache@hege.li
         Resolution|---                         |FIXED

--- Comment #7 from Henrik Krohns <ap...@hege.li> ---
Patch testedly works.

Sending        trunk/build/mkupdates/listpromotable
Transmitting file data .done
Committing transaction...
Committed revision 1889050.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7505] build/mkupdates/listpromotable deprecated goto

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7505

--- Comment #3 from Karsten Bräckelmann <gu...@rudersport.de> ---
Use "redo" instead of deprecated "goto" (jumping into a construct) to restart
the current foreach iteration.

I don't fully understand when the first if-block is (not) entered. Thus using a
dedicated variable to ensure entering the if-block in the case of restarting
the iteration with a new offset.

Review appreciated.

Not comitting to trunk yet, to not risk breaking rules promotion with a release
pending.

I cannot easily test the actual code in listpromotable. Dave, any chance you
can test this?

-- 
You are receiving this mail because:
You are the assignee for the bug.