You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/03/29 13:57:46 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request, #34766: GH-31880: [Python] Table.filter with expression now preserves order with use_threads=True
jorisvandenbossche opened a new pull request, #34766:
URL: https://github.com/apache/arrow/pull/34766
### Rationale for this change
Thanks to https://github.com/apache/arrow/pull/34137, the ExecPlan now has a concept of ordering. When the source node is a Table, the order of the batches in the table is used as the implicit order. And when executing a plan and producing a resulting Table, the default for QueryOptions' `sequence_output` is to honor an order if there is one.
Given that the `Table.filter` method only consists of a table source node (which adds implicit order) and a filter node (which preserves any ordering), the output will now always be ordered by default, also with the default of `use_threads=True`
### Are these changes tested?
The existing test `test_exec_plan.py::test_filter_table_ordering` still passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #34766: GH-31880: [Python] Table.filter with expression now preserves order with use_threads=True
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #34766:
URL: https://github.com/apache/arrow/pull/34766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34766: GH-31880: [Python] Table.filter with expression now preserves order with use_threads=True
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34766:
URL: https://github.com/apache/arrow/pull/34766#issuecomment-1488672123
* Closes: #31880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34766: GH-31880: [Python] Table.filter with expression now preserves order with use_threads=True
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34766:
URL: https://github.com/apache/arrow/pull/34766#issuecomment-1496547065
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/898543c19cdb4d18aff468bc2920ade9...409b15538c2242918cf9f615a0e4a4b5/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34766: GH-31880: [Python] Table.filter with expression now preserves order with use_threads=True
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34766:
URL: https://github.com/apache/arrow/pull/34766#issuecomment-1496546190
Benchmark runs are scheduled for baseline = d6d824d1270956e99113bad36be63d7a1482dd97 and contender = c074e334330edb85857f13db8c9b1e2f5fd2b77d. c074e334330edb85857f13db8c9b1e2f5fd2b77d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0e907b1cfcfd4febb5f257aaeb0de36b...5a66c110b82a40dea255eaf03f6132bf/)
[Failed :arrow_down:0.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/898543c19cdb4d18aff468bc2920ade9...409b15538c2242918cf9f615a0e4a4b5/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/dbcbf3b2dd364ab9958565111153c141...e79c0e2509e2471c82999c6380f7fc61/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bd6b2fc34a394a87ac5e80394b5cf8d9...49b0fd4e69074641a78b9f99a54115ab/)
Buildkite builds:
[Finished] [`c074e334` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2625)
[Failed] [`c074e334` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2657)
[Finished] [`c074e334` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2623)
[Failed] [`c074e334` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2648)
[Finished] [`d6d824d1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2624)
[Failed] [`d6d824d1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2656)
[Finished] [`d6d824d1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2622)
[Failed] [`d6d824d1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2647)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org