You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 15:43:57 UTC

[GitHub] [airflow] ashb opened a new pull request, #22952: Ensure that BackfillJob re-runs existing mapped task instances

ashb opened a new pull request, #22952:
URL: https://github.com/apache/airflow/pull/22952

   `expand_mapped_task` only returns _new_ TaskInstances, so if a backfill
   job was run for a dag that already existed the mapped task would never
   be executed.
   
   The test for this is a bit more direct/tied to the implementation than I'm happy with, but this does test the problem and make the test quick to run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #22952: Ensure that BackfillJob re-runs existing mapped task instances

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #22952:
URL: https://github.com/apache/airflow/pull/22952#issuecomment-1097048040

   This interface also isn't the best, and we could probably do with refactoring it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] github-actions[bot] commented on pull request #22952: Ensure that BackfillJob re-runs existing mapped task instances

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22952:
URL: https://github.com/apache/airflow/pull/22952#issuecomment-1096938366

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb merged pull request #22952: Ensure that BackfillJob re-runs existing mapped task instances

Posted by GitBox <gi...@apache.org>.
ashb merged PR #22952:
URL: https://github.com/apache/airflow/pull/22952


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org