[GitHub] [spark] HyukjinKwon commented on a change in pull request #34674: [SPARK-37419][PYTHON][ML] Rewrite _shared_params_code_gen.py to inline type hints for ml/param/shared.py

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34674:
URL: https://github.com/apache/spark/pull/34674#discussion_r753879983



##########
File path: python/pyspark/ml/param/__init__.pyi
##########
@@ -94,3 +94,6 @@ class Params(pyspark.ml.util.Identifiable, metaclass=abc.ABCMeta):
     def copy(self, extra: Optional[pyspark.ml._typing.ParamMap] = ...) -> Params: ...
     def set(self, param: Param, value: Any) -> None: ...
     def clear(self, param: Param) -> None: ...
+    def _setDefault(self: P, **kwargs: Any) -> P: ...
+    @staticmethod
+    def _dummy() -> Params: ...

Review comment:
       just for doubly sure, this is to avoid mypy complaints right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org