You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by re...@apache.org on 2013/04/26 23:26:55 UTC
svn commit: r1476407 - /uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java

Author: rec
Date: Fri Apr 26 21:26:55 2013
New Revision: 1476407

URL: http://svn.apache.org/r1476407
Log:
[UIMA-2783] Variables that are final and static should be in all caps 
- Changed writing to JAVA_UIMA_TYPE_MAP and made map private

Modified:
    uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java

Modified: uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java?rev=1476407&r1=1476406&r2=1476407&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit/src/main/java/org/apache/uima/fit/factory/ConfigurationParameterFactory.java Fri Apr 26 21:26:55 2013
@@ -57,17 +57,17 @@ public final class ConfigurationParamete
    * A mapping from Java class names to UIMA configuration parameter type names. Used by
    * setConfigurationParameters().
    */
-  public static final Map<String, String> javaUimaTypeMap = new HashMap<String, String>();
+  private static final Map<String, String> JAVA_UIMA_TYPE_MAP = new HashMap<String, String>();
   static {
-    javaUimaTypeMap.put(Boolean.class.getName(), ConfigurationParameter.TYPE_BOOLEAN);
-    javaUimaTypeMap.put(Float.class.getName(), ConfigurationParameter.TYPE_FLOAT);
-    javaUimaTypeMap.put(Double.class.getName(), ConfigurationParameter.TYPE_FLOAT);
-    javaUimaTypeMap.put(Integer.class.getName(), ConfigurationParameter.TYPE_INTEGER);
-    javaUimaTypeMap.put(String.class.getName(), ConfigurationParameter.TYPE_STRING);
-    javaUimaTypeMap.put("boolean", ConfigurationParameter.TYPE_BOOLEAN);
-    javaUimaTypeMap.put("float", ConfigurationParameter.TYPE_FLOAT);
-    javaUimaTypeMap.put("double", ConfigurationParameter.TYPE_FLOAT);
-    javaUimaTypeMap.put("int", ConfigurationParameter.TYPE_INTEGER);
+    JAVA_UIMA_TYPE_MAP.put(Boolean.class.getName(), ConfigurationParameter.TYPE_BOOLEAN);
+    JAVA_UIMA_TYPE_MAP.put(Float.class.getName(), ConfigurationParameter.TYPE_FLOAT);
+    JAVA_UIMA_TYPE_MAP.put(Double.class.getName(), ConfigurationParameter.TYPE_FLOAT);
+    JAVA_UIMA_TYPE_MAP.put(Integer.class.getName(), ConfigurationParameter.TYPE_INTEGER);
+    JAVA_UIMA_TYPE_MAP.put(String.class.getName(), ConfigurationParameter.TYPE_STRING);
+    JAVA_UIMA_TYPE_MAP.put("boolean", ConfigurationParameter.TYPE_BOOLEAN);
+    JAVA_UIMA_TYPE_MAP.put("float", ConfigurationParameter.TYPE_FLOAT);
+    JAVA_UIMA_TYPE_MAP.put("double", ConfigurationParameter.TYPE_FLOAT);
+    JAVA_UIMA_TYPE_MAP.put("int", ConfigurationParameter.TYPE_INTEGER);
 
   }
 
@@ -159,7 +159,7 @@ public final class ConfigurationParamete
     } else {
       parameterClassName = parameterClass.getName();
     }
-    String parameterType = javaUimaTypeMap.get(parameterClassName);
+    String parameterType = JAVA_UIMA_TYPE_MAP.get(parameterClassName);
     if (parameterType == null) {
       return ConfigurationParameter.TYPE_STRING;
     }
@@ -223,7 +223,7 @@ public final class ConfigurationParamete
       parameterClassName = parameterClass.getName();
     }
 
-    String parameterType = javaUimaTypeMap.get(parameterClassName);
+    String parameterType = JAVA_UIMA_TYPE_MAP.get(parameterClassName);
     if (parameterType == null) {
       // If we cannot map the type, we'll try to convert it to a String
       parameterType = ConfigurationParameter.TYPE_STRING;