You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/11/16 03:02:58 UTC
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/860
TAJO-1977: Cannot recognize the space-contained tablename and databasename
I found some bugs in using ```\c``` and ```\d```. Purose of this PR is to fixing them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1977
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #860
----
commit 2c860d549f2d479b9b9bb5c8d9ffc8947561b7f4
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-11-16T01:40:04Z
blank support in ConnectDatabaseCommand
commit 74a0f6536236ce6a41becac0c7a929a0d442201a
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-11-16T01:49:05Z
blank support in DescTableCommand
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-157245994
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-157235243
@jihoonson Thanks for your review. I remove ```testDescTable.result``` via ```git rm``` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-156911280
It will be better to add a new test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/860#discussion_r44930822
--- Diff: tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java ---
@@ -228,17 +237,26 @@ private void verifyDescTable(String sql, String tableName, String resultFileName
}
}
- @Test
- public void testDescTable() throws Exception {
+ public void testDescTable(String testTableName, String resultFileName) throws Exception {
String tableName;
if (cluster.isHiveCatalogStoreRunning()) {
- tableName = "TEST_DESC_TABLE".toLowerCase();
+ tableName = testTableName.toLowerCase();
} else {
- tableName = "TEST_DESC_TABLE";
+ tableName = testTableName;
}
String sql = "create table \"" + tableName + "\" (col1 int4, col2 int4);";
- verifyDescTable(sql, tableName, "testDescTable.result");
--- End diff --
If this file does not used anymore, please remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-156904252
May I use used unit? or create another new unit? I guess I can make some test related of this PR with used unit like TestTajoCli::testConnectDatabase and TestTajoCli::testDescTable to add some code line more in that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-156901742
You need to add some tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1977: Cannot recognize the space-contained...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/860#issuecomment-156920057
@jihoonson I add a new unit test. Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---