You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/01/30 05:09:03 UTC
Review Request: Resource Monitoring 9: Implemented process based resource
collection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This implements process isolation module resource collection for linux.
My following change implements the OSX version.
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs
-----
src/slave/process_based_isolation_module.hpp f1817192582e3646f8dcf17934ba7998829e8fd6
src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
Diff: https://reviews.apache.org/r/9146/diff/
Testing
-------
End-to-end via the webui.
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/#review15973
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 30, 2013, 4:09 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9146/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 4:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This implements process isolation module resource collection for linux.
>
> My following change implements the OSX version.
>
>
> This addresses bug MESOS-324.
> https://issues.apache.org/jira/browse/MESOS-324
>
>
> Diffs
> -----
>
> src/slave/process_based_isolation_module.hpp f1817192582e3646f8dcf17934ba7998829e8fd6
> src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
>
> Diff: https://reviews.apache.org/r/9146/diff/
>
>
> Testing
> -------
>
> End-to-end via the webui.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 7:17 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
This implements process isolation module resource collection for linux.
My following change implements the OSX version.
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs (updated)
-----
src/slave/process_based_isolation_module.cpp 12a579cba56cd3dac384bc7919b0d5537b0e429d
Diff: https://reviews.apache.org/r/9146/diff/
Testing
-------
End-to-end via the webui.
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 12:32 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Benh review.
Rebased off trunk.
Description
-------
This implements process isolation module resource collection for linux.
My following change implements the OSX version.
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs (updated)
-----
src/slave/process_based_isolation_module.cpp 12a579cba56cd3dac384bc7919b0d5537b0e429d
Diff: https://reviews.apache.org/r/9146/diff/
Testing
-------
End-to-end via the webui.
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 21, 2013, 1:50 a.m., Benjamin Hindman wrote:
> > src/slave/process_based_isolation_module.cpp, line 278
> > <https://reviews.apache.org/r/9146/diff/2/?file=258502#file258502line278>
> >
> > Move this down just below 'ProcessInfo* Info =' and above 'result.set_timestamp...'.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/#review16821
-----------------------------------------------------------
On Feb. 13, 2013, 2:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9146/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 2:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This implements process isolation module resource collection for linux.
>
> My following change implements the OSX version.
>
>
> This addresses bug MESOS-324.
> https://issues.apache.org/jira/browse/MESOS-324
>
>
> Diffs
> -----
>
> src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
>
> Diff: https://reviews.apache.org/r/9146/diff/
>
>
> Testing
> -------
>
> End-to-end via the webui.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/#review16821
-----------------------------------------------------------
Ship it!
src/slave/process_based_isolation_module.cpp
<https://reviews.apache.org/r/9146/#comment35736>
Move this down just below 'ProcessInfo* Info =' and above 'result.set_timestamp...'.
src/slave/process_based_isolation_module.cpp
<https://reviews.apache.org/r/9146/#comment35735>
Please merge this with ifdef linux below.
- Benjamin Hindman
On Feb. 13, 2013, 2:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9146/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 2:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This implements process isolation module resource collection for linux.
>
> My following change implements the OSX version.
>
>
> This addresses bug MESOS-324.
> https://issues.apache.org/jira/browse/MESOS-324
>
>
> Diffs
> -----
>
> src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
>
> Diff: https://reviews.apache.org/r/9146/diff/
>
>
> Testing
> -------
>
> End-to-end via the webui.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/#review16820
-----------------------------------------------------------
Ship it!
src/slave/process_based_isolation_module.cpp
<https://reviews.apache.org/r/9146/#comment35734>
ifdef please.
src/slave/process_based_isolation_module.cpp
<https://reviews.apache.org/r/9146/#comment35733>
Kill.
- Benjamin Hindman
On Feb. 13, 2013, 2:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9146/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 2:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This implements process isolation module resource collection for linux.
>
> My following change implements the OSX version.
>
>
> This addresses bug MESOS-324.
> https://issues.apache.org/jira/browse/MESOS-324
>
>
> Diffs
> -----
>
> src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
>
> Diff: https://reviews.apache.org/r/9146/diff/
>
>
> Testing
> -------
>
> End-to-end via the webui.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 9: Implemented process based
resource collection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9146/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 2:55 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated with isolation module changes upstream.
Description
-------
This implements process isolation module resource collection for linux.
My following change implements the OSX version.
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs (updated)
-----
src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
Diff: https://reviews.apache.org/r/9146/diff/
Testing
-------
End-to-end via the webui.
Thanks,
Ben Mahler