You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amruth Sampath <am...@flipkart.com> on 2015/11/03 12:09:29 UTC

Question regarding commits

Hi i am following these steps for committing
https://lens.apache.org/developer/commit.html
<https://www.google.com/url?q=https%3A%2F%2Flens.apache.org%2Fdeveloper%2Fcommit.html&sa=D&sntz=1&usg=AFQjCNEvYBFxMM70I1W963kzKQuk2pwXIQ>
It says i ll have to add developer tag... but the example seem to have
something called 'PPMC' role. Should I remove that?

Also should I make this as a separate commit? If yes, what is the message
template?

Thanks,
-- 
Amruth S
(09486075517)

Re: Question regarding commits

Posted by "amareshwarisr ." <am...@gmail.com>.
Any meaningful message conveying the commit should be fine.

On Tue, Nov 3, 2015 at 5:20 PM, Amruth Sampath <am...@flipkart.com>
wrote:

> Sure. What about the commit message template for new developer.
>
> Should I just say "Changes to pom.xml New developer - 1st commit" ?
>
> On Tue, Nov 3, 2015 at 5:05 PM, amareshwarisr . <am...@gmail.com>
> wrote:
>
> > Hello Amruth,
> >
> > Yes, example and pom.xml needs fixing.
> > It should also say PMC instead of PPMC, as we are not incubating any
> more.
> >
> > And we should update documentation to mention, if you are invited as
> > committer - role is committer. If you are invited as PMC, role would say
> > both PMC and Committer.
> >
> > Can you do above changes and also add youself as committer?
> >
> > Thanks
> > Amareshwari
> >
> > On Tue, Nov 3, 2015 at 4:39 PM, Amruth Sampath <am...@flipkart.com>
> > wrote:
> >
> > > Hi i am following these steps for committing
> > > https://lens.apache.org/developer/commit.html
> > > <
> > >
> >
> https://www.google.com/url?q=https%3A%2F%2Flens.apache.org%2Fdeveloper%2Fcommit.html&sa=D&sntz=1&usg=AFQjCNEvYBFxMM70I1W963kzKQuk2pwXIQ
> > > >
> > > It says i ll have to add developer tag... but the example seem to have
> > > something called 'PPMC' role. Should I remove that?
> > >
> > > Also should I make this as a separate commit? If yes, what is the
> message
> > > template?
> > >
> > > Thanks,
> > > --
> > > Amruth S
> > > (09486075517)
> > >
> >
>
>
>
> --
> Amruth S
> (09486075517)
>

Re: Question regarding commits

Posted by Amruth Sampath <am...@flipkart.com>.
Sure. What about the commit message template for new developer.

Should I just say "Changes to pom.xml New developer - 1st commit" ?

On Tue, Nov 3, 2015 at 5:05 PM, amareshwarisr . <am...@gmail.com>
wrote:

> Hello Amruth,
>
> Yes, example and pom.xml needs fixing.
> It should also say PMC instead of PPMC, as we are not incubating any more.
>
> And we should update documentation to mention, if you are invited as
> committer - role is committer. If you are invited as PMC, role would say
> both PMC and Committer.
>
> Can you do above changes and also add youself as committer?
>
> Thanks
> Amareshwari
>
> On Tue, Nov 3, 2015 at 4:39 PM, Amruth Sampath <am...@flipkart.com>
> wrote:
>
> > Hi i am following these steps for committing
> > https://lens.apache.org/developer/commit.html
> > <
> >
> https://www.google.com/url?q=https%3A%2F%2Flens.apache.org%2Fdeveloper%2Fcommit.html&sa=D&sntz=1&usg=AFQjCNEvYBFxMM70I1W963kzKQuk2pwXIQ
> > >
> > It says i ll have to add developer tag... but the example seem to have
> > something called 'PPMC' role. Should I remove that?
> >
> > Also should I make this as a separate commit? If yes, what is the message
> > template?
> >
> > Thanks,
> > --
> > Amruth S
> > (09486075517)
> >
>



-- 
Amruth S
(09486075517)

Re: Question regarding commits

Posted by "amareshwarisr ." <am...@gmail.com>.
Hello Amruth,

Yes, example and pom.xml needs fixing.
It should also say PMC instead of PPMC, as we are not incubating any more.

And we should update documentation to mention, if you are invited as
committer - role is committer. If you are invited as PMC, role would say
both PMC and Committer.

Can you do above changes and also add youself as committer?

Thanks
Amareshwari

On Tue, Nov 3, 2015 at 4:39 PM, Amruth Sampath <am...@flipkart.com>
wrote:

> Hi i am following these steps for committing
> https://lens.apache.org/developer/commit.html
> <
> https://www.google.com/url?q=https%3A%2F%2Flens.apache.org%2Fdeveloper%2Fcommit.html&sa=D&sntz=1&usg=AFQjCNEvYBFxMM70I1W963kzKQuk2pwXIQ
> >
> It says i ll have to add developer tag... but the example seem to have
> something called 'PPMC' role. Should I remove that?
>
> Also should I make this as a separate commit? If yes, what is the message
> template?
>
> Thanks,
> --
> Amruth S
> (09486075517)
>