[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6398: Reformat H3 index config spec

[GitBox <gi...@apache.org>]

yupeng9 commented on a change in pull request #6398:
URL: https://github.com/apache/incubator-pinot/pull/6398#discussion_r550733577



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/H3IndexColumn.java
##########
@@ -21,30 +21,48 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.base.Preconditions;
+import java.util.ArrayList;
 import java.util.List;
+import java.util.Map;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.pinot.spi.config.BaseJsonConfig;
 
 
-public class H3IndexConfig extends BaseJsonConfig {
+public class H3IndexColumn extends BaseJsonConfig {

Review comment:
       I think we can keep it as it's possible to introduce a POJO for index column and use polymorphism to support this H3indexColumn




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org