You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/11/17 14:25:16 UTC
svn commit: r1869946 - in
/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature:
CreateEmbeddedTimeStamp.java CreateSignedTimeStamp.java SigUtils.java
cert/OcspHelper.java validation/AddValidationInformation.java
Author: tilman
Date: Sun Nov 17 14:25:16 2019
New Revision: 1869946
URL: http://svn.apache.org/viewvc?rev=1869946&view=rev
Log:
PDFBOX-4071: SonarQube fix: remove exception that won't be thrown
Modified:
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateEmbeddedTimeStamp.java
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignedTimeStamp.java
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/SigUtils.java
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateEmbeddedTimeStamp.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateEmbeddedTimeStamp.java?rev=1869946&r1=1869945&r2=1869946&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateEmbeddedTimeStamp.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateEmbeddedTimeStamp.java Sun Nov 17 14:25:16 2019
@@ -181,9 +181,8 @@ public class CreateEmbeddedTimeStamp
* Extracts last Document-Signature from the document. The signature will be set on the signature-field.
*
* @param document to get the Signature from
- * @throws IOException
*/
- private void getRelevantSignature(PDDocument document) throws IOException
+ private void getRelevantSignature(PDDocument document)
{
// we can't use getLastSignatureDictionary() because this will fail (see PDFBOX-3978)
// if a signature is assigned to a pre-defined empty signature field that isn't the last.
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignedTimeStamp.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignedTimeStamp.java?rev=1869946&r1=1869945&r2=1869946&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignedTimeStamp.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignedTimeStamp.java Sun Nov 17 14:25:16 2019
@@ -141,7 +141,7 @@ public class CreateSignedTimeStamp imple
return new byte[] {};
}
- public static void main(String[] args) throws IOException, GeneralSecurityException
+ public static void main(String[] args) throws IOException
{
if (args.length != 3)
{
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/SigUtils.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/SigUtils.java?rev=1869946&r1=1869945&r2=1869946&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/SigUtils.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/SigUtils.java Sun Nov 17 14:25:16 2019
@@ -215,9 +215,8 @@ public class SigUtils
*
* @param document to get its last signature
* @return last signature or null when none found
- * @throws IOException
*/
- public static PDSignature getLastRelevantSignature(PDDocument document) throws IOException
+ public static PDSignature getLastRelevantSignature(PDDocument document)
{
SortedMap<Integer, PDSignature> sortedMap = new TreeMap<>();
for (PDSignature signature : document.getSignatureDictionaries())
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java?rev=1869946&r1=1869945&r2=1869946&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java Sun Nov 17 14:25:16 2019
@@ -232,7 +232,7 @@ public class OcspHelper
}
}
- private byte[] getKeyHashFromCertHolder(X509CertificateHolder certHolder) throws IOException
+ private byte[] getKeyHashFromCertHolder(X509CertificateHolder certHolder)
{
// https://tools.ietf.org/html/rfc2560#section-4.2.1
// KeyHash ::= OCTET STRING -- SHA-1 hash of responder's public key
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java?rev=1869946&r1=1869945&r2=1869946&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java Sun Nov 17 14:25:16 2019
@@ -556,7 +556,7 @@ public class AddValidationInformation
catalog.setVersion("1.7");
}
- public static void main(String[] args) throws IOException, GeneralSecurityException
+ public static void main(String[] args) throws IOException
{
if (args.length != 1)
{