You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/29 17:43:18 UTC

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1739

    [FLINK-3536] Make clearer distinction between event time and processi…

    …ng time
    
    This brings it more in line with *ProcessingTimeWindows and makes it
    clear what type of window assigner it is.
    
    The old name, i.e. SlidingTimeWindows and TumblingTimeWindows is still
    available but deprecated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink window-assigner-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1739
    
----
commit 73570e7b7bc43b1a6b04fac295ed68f3a9d68962
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-29T13:56:29Z

    [FLINK-3536] Make clearer distinction between event time and processing time
    
    This brings it more in line with *ProcessingTimeWindows and makes it
    clear what type of window assigner it is.
    
    The old name, i.e. SlidingTimeWindows and TumblingTimeWindows is still
    available but deprecated.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1739#issuecomment-190318168
  
    Would you like to make this part of the 1.0.0 RC3?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/1739


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1739#issuecomment-190319471
  
    I think it would be good to have it in, yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---