[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29964: [SPARK-32047][SQL]Add JDBC connection provider disable possibility

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #29964:
URL: https://github.com/apache/spark/pull/29964#discussion_r501578769



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
##########
@@ -22,12 +22,15 @@ import java.util.ServiceLoader
 
 import scala.collection.mutable
 
+import org.apache.spark.{SparkConf, SparkEnv}
 import org.apache.spark.internal.Logging
 import org.apache.spark.security.SecurityConfigurationLock
 import org.apache.spark.sql.jdbc.JdbcConnectionProvider
 import org.apache.spark.util.Utils
 
 private[jdbc] object ConnectionProvider extends Logging {
+  private val providerEnabledConfig = "spark.security.jdbc.connection.provider.%s.enabled"

Review comment:
       It makes sense to make it SQL like so adapting. What I think however we need blacklist and not whitelist. Having a blacklist doesn't expect any configuration from user when new provider added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org