You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/12/09 22:49:59 UTC
Review Request 16136: Fixed the python tests in the presence of multiple
eggs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
Diffs
-----
src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
Diff: https://reviews.apache.org/r/16136/diff/
Testing
-------
make check on both OSX and CentOS 5.
Thanks,
Ben Mahler
Re: Review Request 16136: Fixed the python tests in the presence of muliple
eggs.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/#review30078
-----------------------------------------------------------
Ship it!
src/examples/python/test-executor.in
<https://reviews.apache.org/r/16136/#comment57630>
Is there any precedent for wrapping lines like this?
- Benjamin Hindman
On Dec. 10, 2013, 1:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16136/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
>
> Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
>
>
> Diffs
> -----
>
> src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
> src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
>
> Diff: https://reviews.apache.org/r/16136/diff/
>
>
> Testing
> -------
>
> make check on both OSX and CentOS 5.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 16136: Fixed the python tests in the presence of muliple
eggs.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/
-----------------------------------------------------------
(Updated Dec. 10, 2013, 7:31 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Wrapped lines per benh. Did this by removing the use of echo with wildcards in favor of simple string construction.
Repository: mesos-git
Description
-------
The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
Diffs (updated)
-----
src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
Diff: https://reviews.apache.org/r/16136/diff/
Testing
-------
make check on both OSX and CentOS 5.
Thanks,
Ben Mahler
Re: Review Request 16136: Fixed the python tests in the presence of muliple
eggs.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/
-----------------------------------------------------------
(Updated Dec. 10, 2013, 1:04 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
This now uses the existing egg postfix variables.
Summary (updated)
-----------------
Fixed the python tests in the presence of muliple eggs.
Repository: mesos-git
Description
-------
The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
Diffs (updated)
-----
src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
Diff: https://reviews.apache.org/r/16136/diff/
Testing
-------
make check on both OSX and CentOS 5.
Thanks,
Ben Mahler
Re: Review Request 16136: Fixed the python tests in the presence of muliple
eggs.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 9, 2013, 10:22 p.m., Benjamin Hindman wrote:
> > src/examples/python/test-executor.in, line 16
> > <https://reviews.apache.org/r/16136/diff/1/?file=395813#file395813line16>
> >
> > Can we set PYTHON_VERSION in our automake variables and then use that instead of EGG_PYTHON_VERSION?
Turns out we already have the postfix variables! Used those instead.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/#review30053
-----------------------------------------------------------
On Dec. 10, 2013, 1:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16136/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 1:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
>
> Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
>
>
> Diffs
> -----
>
> src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
> src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
>
> Diff: https://reviews.apache.org/r/16136/diff/
>
>
> Testing
> -------
>
> make check on both OSX and CentOS 5.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 16136: Fixed the python tests in the presence of multiple
eggs.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16136/#review30053
-----------------------------------------------------------
src/examples/python/test-executor.in
<https://reviews.apache.org/r/16136/#comment57567>
Can we set PYTHON_VERSION in our automake variables and then use that instead of EGG_PYTHON_VERSION?
- Benjamin Hindman
On Dec. 9, 2013, 9:49 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16136/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 9:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The python framework tests fail when there are multiple eggs present. This is because the scripts use overly general wildcards to match the egg files.
>
> Multiple eggs can be present due to multiple mesos versions, as well as multiple python versions having ran through make check.
>
>
> Diffs
> -----
>
> src/examples/python/test-executor.in 6f18682425b472b58fe4f42859d84cbb24da9f7c
> src/examples/python/test-framework.in d66cf6bd6f6ecdfc917d2ac004cf32e61ce150c5
>
> Diff: https://reviews.apache.org/r/16136/diff/
>
>
> Testing
> -------
>
> make check on both OSX and CentOS 5.
>
>
> Thanks,
>
> Ben Mahler
>
>