You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/23 18:32:07 UTC

svn commit: r1883761 - in /pdfbox/trunk/pdfbox/src/test: java/org/apache/pdfbox/rendering/TestRendering.java resources/junit-platform.properties

Author: msahyoun
Date: Mon Nov 23 18:32:07 2020
New Revision: 1883761

URL: http://svn.apache.org/viewvc?rev=1883761&view=rev
Log:
PDFBOX-5017: enable test to run in parallel; limit number of test files

Added:
    pdfbox/trunk/pdfbox/src/test/resources/junit-platform.properties
Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java?rev=1883761&r1=1883760&r2=1883761&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java Mon Nov 23 18:32:07 2020
@@ -22,6 +22,8 @@ import org.apache.pdfbox.pdmodel.PDDocum
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 
 import static org.junit.jupiter.api.Assertions.fail;
 
@@ -39,19 +41,21 @@ import java.util.stream.Stream;
  *
  * @author John Hewson
  */
+@Execution(ExecutionMode.CONCURRENT)
 public class TestRendering
 {
     private static final String INPUT_DIR = "src/test/resources/input/rendering";
     private static final String OUTPUT_DIR = "target/test-output/rendering/";
+    private static final int MAX_NUM_FILES = 20;
 
     public static Collection<Arguments> data()
     {
         File[] testFiles = new File(INPUT_DIR).listFiles(
                 (dir, name) -> (name.endsWith(".pdf") || name.endsWith(".ai")));
-        return Stream.of(testFiles).map(file -> Arguments.of(file.getName())).collect(Collectors.toList());
+        return Stream.of(testFiles).map(file -> Arguments.of(file.getName())).limit(MAX_NUM_FILES).collect(Collectors.toList());
     }
 
-    @ParameterizedTest
+    @ParameterizedTest(name = "{index} render running for {0}")
 	@MethodSource("data")
     public void render(String fileName) throws IOException
     {
@@ -68,7 +72,11 @@ public class TestRendering
         document.close();
     }
 
-    // @ParameterizedTest
+    /*
+     * Test currently disabled as different JVMs produce different results.
+     * Enable and visually inspect failing tests files.
+     */
+    // @ParameterizedTest(name = "{index} render and compare running for {0}")
 	@MethodSource("data")
     public void renderAndCompare(String fileName) throws IOException
     {

Added: pdfbox/trunk/pdfbox/src/test/resources/junit-platform.properties
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/resources/junit-platform.properties?rev=1883761&view=auto
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/resources/junit-platform.properties (added)
+++ pdfbox/trunk/pdfbox/src/test/resources/junit-platform.properties Mon Nov 23 18:32:07 2020
@@ -0,0 +1,3 @@
+junit.jupiter.execution.parallel.enabled = true
+junit.jupiter.execution.parallel.mode.default = same_thread
+junit.jupiter.execution.parallel.mode.classes.default = concurrent
\ No newline at end of file