You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/07 02:06:43 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1766: Revise cloud scheduler authentication

TeslaCN opened a new pull request #1766:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1766


   Changes proposed in this pull request:
   - Disable GSON HTML escaping.
   - Revise code style.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1766: Revise cloud scheduler authentication

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1766:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1766#issuecomment-739621754


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=h1) Report
   > Merging [#1766](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=desc) (b475b31) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/f36dbec98210fc8a01b2f3972896e6ecbefbf59b?el=desc) (f36dbec) will **decrease** coverage by `0.03%`.
   > The diff coverage is `93.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1766      +/-   ##
   ============================================
   - Coverage     86.08%   86.05%   -0.04%     
     Complexity      110      110              
   ============================================
     Files           262      261       -1     
     Lines          5822     5822              
     Branches        894      894              
   ============================================
   - Hits           5012     5010       -2     
     Misses          487      487              
   - Partials        323      325       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...job/cloud/console/security/AuthenticationInfo.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uSW5mby5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...b/cloud/console/security/AuthenticationFilter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uRmlsdGVyLmphdmE=) | `96.55% <92.30%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../cloud/console/security/AuthenticationService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uU2VydmljZS5qYXZh) | `77.77% <100.00%> (+2.77%)` | `0.00 <0.00> (ø)` | |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=footer). Last update [f36dbec...b475b31](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1766: Revise cloud scheduler authentication

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1766:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1766#issuecomment-739621754


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=h1) Report
   > Merging [#1766](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=desc) (b475b31) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/f36dbec98210fc8a01b2f3972896e6ecbefbf59b?el=desc) (f36dbec) will **increase** coverage by `0.01%`.
   > The diff coverage is `93.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1766      +/-   ##
   ============================================
   + Coverage     86.08%   86.10%   +0.01%     
     Complexity      110      110              
   ============================================
     Files           262      261       -1     
     Lines          5822     5822              
     Branches        894      894              
   ============================================
   + Hits           5012     5013       +1     
   + Misses          487      486       -1     
     Partials        323      323              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...job/cloud/console/security/AuthenticationInfo.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uSW5mby5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...b/cloud/console/security/AuthenticationFilter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uRmlsdGVyLmphdmE=) | `96.55% <92.30%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../cloud/console/security/AuthenticationService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uU2VydmljZS5qYXZh) | `77.77% <100.00%> (+2.77%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=footer). Last update [f36dbec...b475b31](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1766: Revise cloud scheduler authentication

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1766:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1766


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org