You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/11/10 15:26:11 UTC
Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags,
2. archive_dir() and archive_directory_dereference() should store
relative paths
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, and Jonathan Hurley.
Bugs: AMBARI-22413
https://issues.apache.org/jira/browse/AMBARI-22413
Repository: ambari
Description
-------
Removed verbosity flag and fixed the two methods to store relative paths.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py e6d8924
ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347
ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8
Diff: https://reviews.apache.org/r/63725/diff/1/
Testing
-------
- Manually tested archiving / restoration at Falcon server start / stop.
- Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP upgrade (didn't not test the archival process only that upgrade went smoothly)
- Updates python unit tests. All python unit tests pass in ambari-server
Thanks,
Balázs Bence Sári
Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity
flags,
2. archive_dir() and archive_directory_dereference() should store relative
paths
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190727
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On Nov. 10, 2017, 4:26 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 4:26 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, and Jonathan Hurley.
>
>
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed verbosity flag and fixed the two methods to store relative paths.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py e6d8924
> ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347
> ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8
>
>
> Diff: https://reviews.apache.org/r/63725/diff/1/
>
>
> Testing
> -------
>
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity
flags,
2. archive_dir() and archive_directory_dereference() should store relative
paths
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190726
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Nov. 10, 2017, 3:26 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 3:26 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, and Jonathan Hurley.
>
>
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed verbosity flag and fixed the two methods to store relative paths.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py e6d8924
> ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347
> ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8
>
>
> Diff: https://reviews.apache.org/r/63725/diff/1/
>
>
> Testing
> -------
>
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity
flags,
2. archive_dir() and archive_directory_dereference() should store relative
paths
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190750
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Nov. 10, 2017, 10:26 a.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 10:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, and Jonathan Hurley.
>
>
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed verbosity flag and fixed the two methods to store relative paths.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py e6d8924
> ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347
> ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8
>
>
> Diff: https://reviews.apache.org/r/63725/diff/1/
>
>
> Testing
> -------
>
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
>
>
> Thanks,
>
> Balázs Bence Sári
>
>