You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mweissdigchg (via GitHub)" <gi...@apache.org> on 2025/10/13 13:29:11 UTC
[PR] CAMEL-22535 [camel]
mweissdigchg opened a new pull request, #19540:
URL: https://github.com/apache/camel/pull/19540
This PR resolves [CAMEL-22535](https://issues.apache.org/jira/browse/CAMEL-22535) and has the following improvements:
- Switches back to the official eclipse-temurin image to improve supply chain security
- Has only one RUN and ENV statement to avoid unnecessary intermediate image layers
- Introduces a new environment variable `CAMEL_JBANG_COMMIT` which pins to a specific version of `dsl/camel-jbang/camel-jbang-main/dist/CamelJBang.java`
- Has the `jbang` and `camel` executables under `/usr/local/bin`, thus no additional `PATH` is required
- Fails if the download of jbang tarball fails (which wasn't the case)
- Extracts only linux binaries from jbang tarball
- Creates a `camel` executable which is pinned to the commit id declared with `CAMEL_JBANG_COMMIT`
- Sets JBang `version.txt`
- Uses `camel` as the new entrypoint
In future builds you have to update `CAMEL_JBANG_COMMIT` in addition to `JBANG_VERSION` and `CAMEL_VERSION` in the Dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22535 [camel]
Posted by "mweissdigchg (via GitHub)" <gi...@apache.org>.
mweissdigchg commented on PR #19540:
URL: https://github.com/apache/camel/pull/19540#issuecomment-3406062434
> I noticed that if we ping the camel-jbang commit from the release 4.15.0, it will still point to 4.14.0 since we're going to update the version only after the release and only after Kamelets has been released. So what we could do is pinning a version pointing to 4.15.0, which won't be in 4.15.0 tag by the way. @mweissdigchg
As there is no camel-jbang release and thus no tags you have to use the commit id from when you update the dependencies in dsl/camel-jbang/camel-jbang-main/dist/CamelJBang.java see below:
```
//DEPS org.apache.camel:camel-bom:${camel.jbang.version:4.14.1}@pom
//DEPS org.apache.camel:camel-jbang-core:${camel.jbang.version:4.14.1}
//DEPS org.apache.camel.kamelets:camel-kamelets:${camel-kamelets.version:4.14.1}
```
As far as I understand JBang those 3 lines define the camel version used in camel-jbang? I would not use tags, not related to this file change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22535 [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #19540:
URL: https://github.com/apache/camel/pull/19540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22535 [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #19540:
URL: https://github.com/apache/camel/pull/19540#issuecomment-3406018890
I noticed that if we ping the camel-jbang commit from the release 4.15.0, it will still point to 4.14.0 since we're going to update the version only after the release and only after Kamelets has been released. So what we could do is pinning a version pointing to 4.15.0, which won't be in 4.15.0 tag by the way. @mweissdigchg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org