You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jonmclean <gi...@git.apache.org> on 2017/05/05 21:21:20 UTC
[GitHub] spark pull request #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throw...
GitHub user jonmclean opened a pull request:
https://github.com/apache/spark/pull/17877
[SPARK-20615][ML][TEST] SparseVector.argmax throws IndexOutOfBoundsException
## What changes were proposed in this pull request?
Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero.
## How was this patch tested?
Tests were added to the existing VectorsSuite to cover this case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jonmclean/spark vectorArgmaxIndexBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17877.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17877
----
commit 2096430261ca5709f09170c9ac523de0b612025f
Author: Jon McLean <jo...@atsid.com>
Date: 2017-05-05T21:01:09Z
Added tests to illustrate bug SPARK-20615
commit 5614f58f530d3d64a99f6196c39206d749ceb87a
Author: Jon McLean <jo...@atsid.com>
Date: 2017-05-05T21:10:07Z
Made SparseVector.argmax return 0 when no values are defined in the vector. This situation can happen when the SparseVector has a size greater than zero but has no defined elements other than zero
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17877
**[Test build #3693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3693/testReport)** for PR 17877 at commit [`5614f58`](https://github.com/apache/spark/commit/5614f58f530d3d64a99f6196c39206d749ceb87a).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17877
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17877
Merged to master/2.2/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17877
**[Test build #3695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3695/testReport)** for PR 17877 at commit [`8969f02`](https://github.com/apache/spark/commit/8969f021cebf70235b3612207ae03cda1c289e47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by jonmclean <gi...@git.apache.org>.
Github user jonmclean commented on the issue:
https://github.com/apache/spark/pull/17877
Fixed the style issue and ran the Scala style check locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17877
**[Test build #3695 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3695/testReport)** for PR 17877 at commit [`8969f02`](https://github.com/apache/spark/commit/8969f021cebf70235b3612207ae03cda1c289e47).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throw...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17877: [SPARK-20615][ML][TEST] SparseVector.argmax throws Index...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17877
**[Test build #3693 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3693/testReport)** for PR 17877 at commit [`5614f58`](https://github.com/apache/spark/commit/5614f58f530d3d64a99f6196c39206d749ceb87a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org