You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Fernando Ribeiro (JIRA)" <ji...@apache.org> on 2011/05/10 15:54:48 UTC

[jira] [Issue Comment Edited] (CAMEL-3956) Move Default Encoding to Component Class in the FreeMarker Component

    [ https://issues.apache.org/jira/browse/CAMEL-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031189#comment-13031189 ] 

Fernando Ribeiro edited comment on CAMEL-3956 at 5/10/11 1:53 PM:
------------------------------------------------------------------

I got what you meant when I read "and use the encoding from Freemarker Configuration", which is not really that the content of the patch. It actually only provided a default value to be passed to the getTemplate method of the Configuration object in the endpoint class.

Anyway I took a closer look at the FreeMarker source code and realized that there is an even better solution, which is going with FreeMarker itself, which defaults to the platform's encoding when none is provided.

Please find the revision attached.

      was (Author: fribeiro):
    I got what you meant when I read "and use the encoding from Freemarker Configuration", which is not really what the patch was meant to change. It actually only provided a default value to be passed to the getTemplate method of the Configuration object in the endpoint class.

Anyway I took a closer look at the FreeMarker source code and realized that there is an even better solution, which is going with FreeMarker itself, which defaults to the platform's encoding when none is provided.

Please find the revision attached.
  
> Move Default Encoding to Component Class in the FreeMarker Component
> --------------------------------------------------------------------
>
>                 Key: CAMEL-3956
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3956
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>         Environment: All Camel environments.
>            Reporter: Fernando Ribeiro
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: patch.txt
>
>
> The default encoding should be set in the component class, like the contentCache parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira