You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/01 07:12:37 UTC

[GitHub] [inlong] haifxu opened a new pull request, #5309: [INLONG-4928][Manager] Modify inlong stream api in manager client

haifxu opened a new pull request, #5309:
URL: https://github.com/apache/inlong/pull/5309

   ### [INLONG-4928][Manager] Modify inlong stream api in manager client
   
   - Fixes #4928 
   
   ### Motivation
   
   Supplement inlong stream api in manager client
   
   ### Modifications
   
   Supplement inlong stream api in manager client
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] haifxu commented on a diff in pull request #5309: [INLONG-4928][Manager] Modify inlong stream API in the Manager client

Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #5309:
URL: https://github.com/apache/inlong/pull/5309#discussion_r935064084


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongStream.java:
##########
@@ -62,7 +62,7 @@ public interface InlongStream {
     StreamSink getSinkInfoByName(String sinkName);
 
     /**
-     * Return data transform node defined in stream(split,string replace etc)
+     * Return data transform node defined in stream(split,string replace etc.)

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #5309: [INLONG-4928][Manager] Modify inlong stream API in the Manager client

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5309:
URL: https://github.com/apache/inlong/pull/5309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] healchow commented on a diff in pull request #5309: [INLONG-4928][Manager] Modify inlong stream api in manager client

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5309:
URL: https://github.com/apache/inlong/pull/5309#discussion_r935051124


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongStream.java:
##########
@@ -62,7 +62,7 @@ public interface InlongStream {
     StreamSink getSinkInfoByName(String sinkName);
 
     /**
-     * Return data transform node defined in stream(split,string replace etc)
+     * Return data transform node defined in stream(split,string replace etc.)

Review Comment:
   Please add a blank after `split,`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org