You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by netroby <gi...@git.apache.org> on 2017/03/31 09:49:13 UTC

[GitHub] incubator-rocketmq-externals pull request #7: Rename README.txt to README.md...

GitHub user netroby opened a pull request:

    https://github.com/apache/incubator-rocketmq-externals/pull/7

    Rename README.txt to README.md; Add windows support

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/netroby/incubator-rocketmq-externals master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq-externals/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 4c003942b2c9a97adf02ce79182c095648365be8
Author: huzhifeng <hu...@douyu.tv>
Date:   2017-03-31T09:48:14Z

    Rename README.txt to README.md; Add windows support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @netroby I want to merge this PR. Could you please provide your email address that could be identified as your github account ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: [ROCKETMQ-170]Rename README.txt to RE...

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @netroby nice. I would merge this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    I have test on windows 7(installed docker toolbox 1.11.1), the result is:
    
    1. Should run _docker-machine_ first, it will tell you set some envs.
    ```
    SET DOCKER_TLS_VERIFY=1
    SET DOCKER_HOST=tcp://192.168.99.100:2376
    SET DOCKER_CERT_PATH=C:\Users\xigu.lx\.docker\machine\machines\default
    SET DOCKER_MACHINE_NAME=default
    REM Run this command to configure your shell:
    REM     @FOR /f "tokens=*" %i IN ('docker-machine.exe env default') DO @%i
    ```
    2. Then run the _docker_build.cmd_
    3. Then run the _docker_run.cmd_
    
    I think you could add the first step(auto config the env) to cmd, maybe!
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: [ROCKETMQ-170]Rename README.txt to RE...

Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @dongeforever @vongosling @zhouxinyu 
    I had made a jira issue . and changed PR title/commit log
    https://issues.apache.org/jira/browse/ROCKETMQ-170


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @vsair @netroby Yeah. how to setup docker env is not the major work here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals pull request #7: [ROCKETMQ-170]Rename README.tx...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rocketmq-externals/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    
    
    how to setup docker may a bit out of topic
    
    
    
    
    On Sat, Apr 1, 2017 at 5:18 PM +0800, "Eric Liu" <no...@github.com> wrote:
    
    
    
    
    
    
    
    
    
    
    
    
    I have test on windows 7(installed docker toolbox 1.11.1), the result is:
    
    Should run docker-machine first, it will tell you set some envs.
    
    SET DOCKER_TLS_VERIFY=1
    SET DOCKER_HOST=tcp://192.168.99.100:2376
    SET DOCKER_CERT_PATH=C:\Users\xigu.lx\.docker\machine\machines\default
    SET DOCKER_MACHINE_NAME=default
    REM Run this command to configure your shell:
    REM     @FOR /f "tokens=*" %i IN ('docker-machine.exe env default') DO @%i
    
    
    Then run the docker_build.cmd
    Then run the docker_run.cmd
    
    
    
    I think you could add the first step(auto config the env) to cmd, maybe!
    
    
    Thanks.
    
    
    
    \u2014
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or mute the thread.
    
    
      
      
    
    
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    Sorry, but no rocketmq-docker component. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @netroby i think you are familiar with rocketmq PR process. Could you modify your PR topic and make association with Jira isssue?Now ,you can not point up the component~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    @vongosling @zhouxinyu please help add the component 'rocketmq-externals' or 'rocketmq-docker'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: Rename README.txt to README.md; Add w...

Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    
    
    hufeng1987@gmail.com
    
    
    
    
    On Mon, Apr 3, 2017 at 10:06 PM +0800, "zander" <no...@github.com> wrote:
    
    
    
    
    
    
    
    
    
    
    
    
    @netroby I want to merge this PR. Could you please provide your email address that could be identified as your github account ?
    
    
    
    \u2014
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub, or mute the thread.
    
    
      
      
    
    
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #7: [ROCKETMQ-170]Rename README.txt to RE...

Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq-externals/pull/7
  
    Thanks for your time


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---