[GitHub] [iceberg] zhongyujiang commented on pull request #7249: Avoid conflicts between rewrite datafiles and flink CDC writes

["zhongyujiang (via GitHub)" <gi...@apache.org>]

zhongyujiang commented on PR #7249:
URL: https://github.com/apache/iceberg/pull/7249#issuecomment-1493999658

   > This solution is similar to my early PR(https://github.com/apache/iceberg/pull/4748, and https://github.com/apache/iceberg/pull/4703). This way is deemed as dangerous so I change to another way ( https://github.com/apache/iceberg/pull/5760)
   
   I think this is different from 4748 because this doesn't allow users to choose to ignore pos deletes. 
   Snapshots submitted by other engines that contain snapshots that may be applied to historical data files will not be ignored, because there will be no 'position-deletes-within-commit-only'='true' in their snapshot summary. And according to this [comment](https://github.com/apache/iceberg/blob/7184691a60e2ac21dfd6b22fba56d2fe60f9af51/flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java#L370), Flink delta txn won't commit pos deletes that can be applied to historical data either. That is to say, there is no risk of ignoring pos deletes can be applied to history data, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org