You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/04/05 20:01:30 UTC
[3/3] qpid-dispatch git commit: DISPATCH-739: Enable valgrind
leak-check=full for definite leaks only.
DISPATCH-739: Enable valgrind leak-check=full for definite leaks only.
Only for definite leaks, avoid deluge of "possibly lost" noise from python.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/db075fee
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/db075fee
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/db075fee
Branch: refs/heads/master
Commit: db075feeac1294c8b2093bc564893e1d5236a43d
Parents: c1ec00c
Author: Alan Conway <ac...@redhat.com>
Authored: Tue Apr 4 14:07:47 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 5 15:53:56 2017 -0400
----------------------------------------------------------------------
run.py.in | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/db075fee/run.py.in
----------------------------------------------------------------------
diff --git a/run.py.in b/run.py.in
index eea8882..266a703 100755
--- a/run.py.in
+++ b/run.py.in
@@ -116,7 +116,12 @@ VALGRIND_ERROR = 42 # magic number indicating valgrind found errors
def with_valgrind(args, outfile=None):
if use_valgrind() and is_binary_exe(find_exe(args[0])):
opts = ['--trace-children=yes',
- # '--leak-check=full', way too noisy due to Python leaks
+ '--leak-check=full',
+ # Python generates a ton of "possibly lost" and "still in use"
+ # false alarms, restrict to "definite" leaks.
+ # Ideally we should have more specific python exclusions.
+ '--show-leak-kinds=definite',
+ '--errors-for-leak-kinds=definite',
'--demangle=yes',
'--num-callers=12',
'--error-exitcode=%d' % VALGRIND_ERROR,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org