You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:42:16 UTC
[GitHub] [spark] wbo4958 opened a new pull request, #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
wbo4958 opened a new pull request, #38410:
URL: https://github.com/apache/spark/pull/38410
### What changes were proposed in this pull request?
The messages returned by allGather may be overridden by the following barrier APIs, eg,
``` scala
val messages: Array[String] = context.allGather("ABC")
context.barrier()
```
the `messages` may be like Array("", ""), but we're expecting Array("ABC", "ABC")
The root cause of this issue is the [messages got by allGather](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/BarrierTaskContext.scala#L102) pointing to the [original message](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/BarrierCoordinator.scala#L107) in the local mode. So when the following barrier APIs changed the messages, then the allGather message will be changed accordingly.
Finally, users can't get the correct result.
This PR fixed this issue by sending back the cloned messages.
### Why are the changes needed?
The bug mentioned in this description may block some external SPARK ML libraries which heavily depend on the spark barrier API to do some synchronization. If the barrier mechanism can't guarantee the correctness of the barrier APIs, it will be a disaster for external SPARK ML libraries.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I added a unit test, with this PR, the unit test can pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wbo4958 commented on pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
Posted by GitBox <gi...@apache.org>.
wbo4958 commented on PR #38410:
URL: https://github.com/apache/spark/pull/38410#issuecomment-1294685220
@cloud-fan could you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
URL: https://github.com/apache/spark/pull/38410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38410:
URL: https://github.com/apache/spark/pull/38410#issuecomment-1293998577
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wbo4958 commented on pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
Posted by GitBox <gi...@apache.org>.
wbo4958 commented on PR #38410:
URL: https://github.com/apache/spark/pull/38410#issuecomment-1293265159
@jiangxb1987 could you help to review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38410: [SPARK-40932][CORE] Fix issue messages for allGather are overridden
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38410:
URL: https://github.com/apache/spark/pull/38410#issuecomment-1294978376
thanks, merging to master/3.3!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org