You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shijinkui <gi...@git.apache.org> on 2016/09/02 02:49:48 UTC
[GitHub] flink pull request #2458: [FLINK-4560] enforcer java version as 1.7
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2458
[FLINK-4560] enforcer java version as 1.7
[FLINK-4560](https://issues.apache.org/jira/browse/FLINK-4560) enforcer java version as 1.7
1. maven-enforcer-plugin add java version enforce
2. maven-enforcer-plugin version upgrade to 1.4.1
explicit require java version
Only modify the root pom file.
The pull request references the related JIRA issue ("[FLINK-4560] enforcer java version as 1.7")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink enforcer_java_version_7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2458
----
commit d4fe8b21ea6680832328cc93b620973bee57ab03
Author: shijinkui <sh...@huawei.com>
Date: 2016-09-02T02:46:45Z
\
[FLINK-4560] enforcer java version as 1.7
1. maven-enforcer-plugin add java version enforce
2. maven-enforcer-plugin version upgrade to 1.4.1
explicit require java version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
@StephanEwen OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2458
From my side, this is good to merge.
Unless someone objects, I will merge this later today...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2458: [FLINK-4560] enforcer java version as 1.7
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2458
We already gave up Java 6, and setting the source and target version in the Maven compiler plugin already prevents Java 6 usage. That is why I am wondering...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2458
Would this be useful to prevent building Flink with Maven 3.3.x?
https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html
https://maven.apache.org/enforcer/enforcer-rules/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
@greghogan exactly 3.0.3 will be OK. This limit is some module require, I forget where it is, I am sorry..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
hi, @StephanEwen
There are much difference between JDK 6 and JDK 7+. It's better for compatible low version JDK\uff0cbut there are better performance for Scala with Lambda support, and JDK 7 and 8 are enhanced on many features.
Now JDK7 is wide used. Give up JDK 6 compatible. It's clearly for developer: use JDK 7+ features relieved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2458
Hi!
Can you explain a bit what this pull request fixes? I think Maven complains by itself if the JDK is of a lower version than the compiler target version. So what changes here?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
enforce java 7 before compile. There is no conflict between source/target and enforcer java version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---