You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/02 15:18:28 UTC
[GitHub] [kafka] cadonna opened a new pull request, #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
cadonna opened a new pull request, #12114:
URL: https://github.com/apache/kafka/pull/12114
Adds a note to the upgrade notes to use slf4j-log4j version
1.7.35+ [1] or slf4j-reload4j to avoid possible compatibility issues
originating from the logging framework [2].
[1] https://www.slf4j.org/manual.html#swapping
[2] https://www.slf4j.org/codes.html#no_tlm
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862968313
##########
docs/upgrade.html:
##########
@@ -73,7 +73,11 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
via Connect worker and/or connector configuration. Connect may enable idempotent producers
by default in a future major release.</li>
<li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
Review Comment:
We should also update the same text in the 3.1 branch once we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12114:
URL: https://github.com/apache/kafka/pull/12114#issuecomment-1115025366
@ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12114:
URL: https://github.com/apache/kafka/pull/12114#issuecomment-1115964688
Cherry-picked to 3.2
Opened PR https://github.com/apache/kafka/pull/12117 for 3.1 since I ran into merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12114:
URL: https://github.com/apache/kafka/pull/12114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
cadonna commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r863082871
##########
docs/upgrade.html:
##########
@@ -73,7 +73,11 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
via Connect worker and/or connector configuration. Connect may enable idempotent producers
by default in a future major release.</li>
<li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
Review Comment:
@ijuma changed the text as you proposed.
I will cherry-pick the commit to 3.2 and 3.1.
@tombentley Since this is just a doc change, we do not need a new RC, right? We can port the change directly to the doc repo in case RC1 passes the votes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862967880
##########
docs/upgrade.html:
##########
@@ -73,7 +73,11 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
via Connect worker and/or connector configuration. Connect may enable idempotent producers
by default in a future major release.</li>
<li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
Review Comment:
Maybe we can say something like:
> <li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
> This only affects modules that specify a logging backend (`connect-runtime` and `kafka-tools` are two such
> examples). A number of modules, including `kafka-clients`, leave it to the application to specify the logging
> backend. More information can be found at <a href"https://reload4j.qos.ch">reload4j</a>.
> Projects that depend on the affected modules from the Kafka project should use
> <a href="https://www.slf4j.org/manual.html#swapping">slf4j-log4j12 version 1.7.35 or above</a> or
> slf4j-reload4j to avoid
> <a href="https://www.slf4j.org/codes.html#no_tlm">possible compatibility issues originating from the logging framework</a>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org