You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/23 15:03:15 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
ustcweizhou opened a new pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496
### Description
This PR fixes the issue that router.aggregation.command.each.timeout on kvm host is reset to 600, when other kvm config is updated, but router.aggregation.command.each.timeout is not.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734956635
<b>Trillian test result (tid-3278)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31220 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4496-t3278-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734721997
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734737839
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733602086
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733602643
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733638090
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734747519
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733732858
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734747035
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#discussion_r530952978
##########
File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##########
@@ -397,7 +397,7 @@ private Answer execute(GetDomRVersionCmd cmd) {
}
public boolean configureHostParams(final Map<String, String> params) {
- if (_params.get("router.aggregation.command.each.timeout") != null) {
+ if (params.get("router.aggregation.command.each.timeout") != null) {
Review comment:
should the field `_param` be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-734721479
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733996114
<b>Trillian test result (tid-3248)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4496-t3248-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#discussion_r530958367
##########
File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##########
@@ -397,7 +397,7 @@ private Answer execute(GetDomRVersionCmd cmd) {
}
public boolean configureHostParams(final Map<String, String> params) {
- if (_params.get("router.aggregation.command.each.timeout") != null) {
+ if (params.get("router.aggregation.command.each.timeout") != null) {
Review comment:
@DaanHoogland yes, will remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4496: kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4496:
URL: https://github.com/apache/cloudstack/pull/4496#issuecomment-733733677
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org