You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2015/01/28 20:34:53 UTC

svn commit: r1655441 - /tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java

Author: rjung
Date: Wed Jan 28 19:34:53 2015
New Revision: 1655441

URL: http://svn.apache.org/r1655441
Log:
Add some code comments for new feature.

Modified:
    tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java

Modified: tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java?rev=1655441&r1=1655440&r2=1655441&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java (original)
+++ tomcat/trunk/java/org/apache/naming/factory/BeanFactory.java Wed Jan 28 19:34:53 2015
@@ -146,6 +146,7 @@ public class BeanFactory
 
                 Object bean = beanClass.newInstance();
 
+                /* Look for properties with explicitly configured setter */
                 RefAddr ra = ref.get("forceString");
                 Map<String, Method> forced = new HashMap<String, Method>();
                 String value;
@@ -157,10 +158,14 @@ public class BeanFactory
                     String setterName;
                     int index;
 
+                    /* Items are given as comma separated list */
                     for (String param: value.split(",")) {
                         param = param.trim();
+                        /* A single item can either be of the form name=method
+                         * or just a property name (and we will use a standard
+                         * setter) */
                         index = param.indexOf('=');
-                        if (index>= 0) {
+                        if (index >= 0) {
                             setterName = param.substring(index + 1).trim();
                             param = param.substring(0, index).trim();
                         } else {
@@ -197,6 +202,7 @@ public class BeanFactory
 
                     Object[] valueArray = new Object[1];
 
+                    /* Shortcut for properties with explicitly configured setter */
                     Method method = forced.get(propName);
                     if (method != null) {
                         valueArray[0] = value;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org