You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/11/15 08:56:58 UTC
Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for uploading
volume
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15570/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
Summary (updated)
-----------------
CLOUDSTACK-5180: Increasing the timeout for uploading volume
Bugs: CLOUDSTACK-5180
https://issues.apache.org/jira/browse/CLOUDSTACK-5180
Repository: cloudstack-git
Description (updated)
-------
Some test cases are failing while uploading the volume just because the time allowed to upload the volume is less in marvin library.
If timeout is increases, these tests pass. Example - component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. This test case has failed in latest build but had passed earlier build.
To avoid this inconsistent behaviour, increased the timeout in "wait_for_upload" function in Volume class in base.py
The test case runs successfully with this change.
Diffs (updated)
-----
tools/marvin/marvin/integration/lib/base.py a3a5f58
Diff: https://reviews.apache.org/r/15570/diff/
Testing (updated)
-------
Tested locally on XenServer basic zone setup.
client Log:
2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully
2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: test-OLJLXM
Result log:
test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume)
Test Upload volume and attach to VM in stopped state ... ok
----------------------------------------------------------------------
Ran 17 tests in 442.869s
OK (skipped=16)
Thanks,
Gaurav Aradhye
Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for
uploading volume
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15570/#review28953
-----------------------------------------------------------
Commit 08208cf427f9957514e3bcc624272c6781a1189a in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08208cf ]
CLOUDSTACK-5180: Increasing the timeout for uploading volume
- ASF Subversion and Git Services
On Nov. 15, 2013, 7:56 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15570/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 7:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5180
> https://issues.apache.org/jira/browse/CLOUDSTACK-5180
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing while uploading the volume just because the time allowed to upload the volume is less in marvin library.
> If timeout is increases, these tests pass. Example - component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. This test case has failed in latest build but had passed earlier build.
>
> To avoid this inconsistent behaviour, increased the timeout in "wait_for_upload" function in Volume class in base.py
> The test case runs successfully with this change.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/base.py a3a5f58
>
> Diff: https://reviews.apache.org/r/15570/diff/
>
>
> Testing
> -------
>
> Tested locally on XenServer basic zone setup.
>
> client Log:
> 2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: test-OLJLXM
>
> Result log:
> test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume)
> Test Upload volume and attach to VM in stopped state ... ok
>
>
> ----------------------------------------------------------------------
> Ran 17 tests in 442.869s
>
> OK (skipped=16)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for
uploading volume
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15570/#review28952
-----------------------------------------------------------
Commit a95bea08e4c41e359c137068245d04bae4d1dff4 in branch refs/heads/4.2 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a95bea0 ]
CLOUDSTACK-5180: Increasing the timeout for uploading volume
- ASF Subversion and Git Services
On Nov. 15, 2013, 7:56 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15570/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 7:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5180
> https://issues.apache.org/jira/browse/CLOUDSTACK-5180
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing while uploading the volume just because the time allowed to upload the volume is less in marvin library.
> If timeout is increases, these tests pass. Example - component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. This test case has failed in latest build but had passed earlier build.
>
> To avoid this inconsistent behaviour, increased the timeout in "wait_for_upload" function in Volume class in base.py
> The test case runs successfully with this change.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/base.py a3a5f58
>
> Diff: https://reviews.apache.org/r/15570/diff/
>
>
> Testing
> -------
>
> Tested locally on XenServer basic zone setup.
>
> client Log:
> 2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: test-OLJLXM
>
> Result log:
> test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume)
> Test Upload volume and attach to VM in stopped state ... ok
>
>
> ----------------------------------------------------------------------
> Ran 17 tests in 442.869s
>
> OK (skipped=16)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for
uploading volume
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15570/#review28955
-----------------------------------------------------------
Commit c141e418e927dadc90a87ad4e1a939091cfbe54e in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c141e41 ]
CLOUDSTACK-5180: Increasing the timeout for uploading volume
- ASF Subversion and Git Services
On Nov. 15, 2013, 7:56 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15570/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 7:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5180
> https://issues.apache.org/jira/browse/CLOUDSTACK-5180
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing while uploading the volume just because the time allowed to upload the volume is less in marvin library.
> If timeout is increases, these tests pass. Example - component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. This test case has failed in latest build but had passed earlier build.
>
> To avoid this inconsistent behaviour, increased the timeout in "wait_for_upload" function in Volume class in base.py
> The test case runs successfully with this change.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/base.py a3a5f58
>
> Diff: https://reviews.apache.org/r/15570/diff/
>
>
> Testing
> -------
>
> Tested locally on XenServer basic zone setup.
>
> client Log:
> 2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: test-OLJLXM
>
> Result log:
> test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume)
> Test Upload volume and attach to VM in stopped state ... ok
>
>
> ----------------------------------------------------------------------
> Ran 17 tests in 442.869s
>
> OK (skipped=16)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for
uploading volume
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15570/#review28954
-----------------------------------------------------------
Ship it!
COmmitted to 4.2, 4.3 and master
- Girish Shilamkar
On Nov. 15, 2013, 7:56 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15570/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 7:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5180
> https://issues.apache.org/jira/browse/CLOUDSTACK-5180
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing while uploading the volume just because the time allowed to upload the volume is less in marvin library.
> If timeout is increases, these tests pass. Example - component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. This test case has failed in latest build but had passed earlier build.
>
> To avoid this inconsistent behaviour, increased the timeout in "wait_for_upload" function in Volume class in base.py
> The test case runs successfully with this change.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/base.py a3a5f58
>
> Diff: https://reviews.apache.org/r/15570/diff/
>
>
> Testing
> -------
>
> Tested locally on XenServer basic zone setup.
>
> client Log:
> 2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully
> 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: test-OLJLXM
>
> Result log:
> test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume)
> Test Upload volume and attach to VM in stopped state ... ok
>
>
> ----------------------------------------------------------------------
> Ran 17 tests in 442.869s
>
> OK (skipped=16)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>