You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/05 06:54:32 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 opened a new pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016
## Description
<!--- Describe your changes in detail -->
When the static route service is not available on the VPC and a static route is created, the static route is created in a revoked state.
Currently, the UI doesn't distinguish between active or revoked static routes.
This PR adds the missing state filter to the list routes command and only lists active routes in the UI.
It also ignores revoked routes when the private gateway is being removed but clears out the inactive routes before the gateway is removed.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes #2908
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This has been tested by creating a VPC with no services, adding a private gateway, adding a static route and deleting the gateway.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669042479
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669844183
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669843440
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669042890
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671839554
> @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway with some static routes (also deploy VMs as VR programming is lazy) and check if VPC VR has a new nic and then removing it removes it both from VR and DB?
@rhtyd I have confirmed that it works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-670216662
<b>Trillian test result (tid-2281)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4016-t2281-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 212.97 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.71 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 316.80 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-666133924
@Spaceman1984 please check comments ^^ thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-654077662
Sorry @rhtyd, I can't give this issue much attention right now, I'm currently busy with a different project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671770446
> @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway with some static routes (also deploy VMs as VR programming is lazy) and check if VPC VR has a new nic and then removing it removes it both from VR and DB?
@rhtyd I'll do some more testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671211245
@DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway and check if VPC VR has a new nic and then removing it removes it both from VR and DB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669097256
@weizhouapache @rhtyd further doubts/questions or are we good to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669054415
@rhtyd I have tested creating and deleting a private gateway, the nic, ip and route is created and removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-648554497
@Spaceman1984 this looks like deletes pg in CloudStack DB, have you verified if this would also cleanup rules on the VR properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-650033575
> @Spaceman1984 this looks like deletes pg in CloudStack DB, have you verified if this would also cleanup rules on the VR properly?
No, I'll check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669018291
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671211245
@DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway with some static routes (also deploy VMs as VR programming is lazy) and check if VPC VR has a new nic and then removing it removes it both from VR and DB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671770446
> @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve the issue or removing it from the DB. @Spaceman1984 did you test the case by adding privategateway with some static routes (also deploy VMs as VR programming is lazy) and check if VPC VR has a new nic and then removing it removes it both from VR and DB?
I'll do some more testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-666294333
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-666294710
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-668398296
@Spaceman1984 ping, any update on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-653724141
ping @Spaceman1984 no update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669029286
Packaging result: ✔centos7 ✔debian. JID-1651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-651681098
@Spaceman1984 private gateway would mean a nic, IP and route on the VR, not iptables rules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-651617355
> @Spaceman1984 this looks like deletes pg in CloudStack DB, have you verified if this would also cleanup rules on the VR properly?
@rhtyd I have checked iptables on the VR before and after trying to add a static route, there is no difference, also this code removes the static route, not the private gateway. Having broken static routes referencing the gateway prevented it from being deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669018672
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#discussion_r469076021
##########
File path: ui/scripts/vpc.js
##########
@@ -2652,7 +2652,8 @@
url: createURL('listStaticRoutes'),
data: {
gatewayid: args.context.vpcGateways[0].id,
- listAll: true
+ listAll: true,
+ state: "Active"
Review comment:
@Spaceman1984 can you send the related change to Primate as well cc @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org