[GitHub] [yunikorn-scheduler-interface] wilfred-s commented on a diff in pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation

[GitBox <gi...@apache.org>]

wilfred-s commented on code in PR #70:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70#discussion_r939745366


##########
scheduler-interface-spec.md:
##########
@@ -505,8 +505,6 @@ message Allocation {
   Resource resourcePerAlloc = 5;
   // Priority of ask
   int32 priority = 6;
-  // Queue which the allocation belongs to
-  string queueName = 7;

Review Comment:
   Can we reserve this ID and name so it cannot be reused?
   ```
   reserved 7;
   reserved "queueName"
   ```
   This will prevent re-using the same ID when we update later, which can cause all kinds of issues. The reserved lines can be  used to replace the existing lines in the message or at the start/end of the message.
   
   NIT: now that we are making a change here fixing the indentation of the lines 505 to 510 might be nice too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org