You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2024/02/08 11:30:49 UTC
[PR] mqtt-streaming: fix flaky 'duplicate publish given two client connections' test [incubator-pekko-connectors]
raboof opened a new pull request, #456:
URL: https://github.com/apache/incubator-pekko-connectors/pull/456
It appears the flakiness was caused by the two connections using the same connection id for different connections in the same session. I'm not intimately familiar with this codebase, but AFAICS it seems this connection id is an internal concern to the component, and not an MQTT concept. I think we should probably provide an API that does not bother the user with this concept at all, and manages non-overlapping connection ids entirely internal to the component. I don't get the impression that it was the purpose of the test to test the behaviour in case of overlapping connection ids.
Fixes #454
After this change the 'unsubscribe a client session' seems to fail a lot on CI, but that seems unrelated and something to fix in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] mqtt-streaming: fix flaky 'duplicate publish given two client connections' test [incubator-pekko-connectors]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #456:
URL: https://github.com/apache/incubator-pekko-connectors/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org