You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Jeffrey Zhong (JIRA)" <ji...@apache.org> on 2014/10/31 18:40:33 UTC
[jira] [Updated] (PHOENIX-1396) Avoid unnecessary ResultSpooler.bin
files creation/deletion every time SpoolingResultIterator is used
[ https://issues.apache.org/jira/browse/PHOENIX-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeffrey Zhong updated PHOENIX-1396:
-----------------------------------
Description:
In SpoolingResultIterator.java, we have following code:
{code}
tempFile = File.createTempFile("ResultSpooler",".bin", new File(spoolDirectory));
DeferredFileOutputStream spoolTo = new DeferredFileOutputStream(size, tempFile) {
{code}
Basically we pre-create spill file even we don't reach memory threshold and later we delete the same file if it's not needed in finally block. We can remove these unnecessary file creation & deletion altogether.
was:
In SpoolingResultIterator.java, we have following code:
{code}
tempFile = File.createTempFile("ResultSpooler",".bin", new File(spoolDirectory));
DeferredFileOutputStream spoolTo = new DeferredFileOutputStream(size, tempFile) {
{code}
Basically we pre-create spill file even we don't cross memory threshold and later we delete in the same file if it's not needed in finally block. We can remove these unnecessary file creation & deletion altogether.
> Avoid unnecessary ResultSpooler.bin files creation/deletion every time SpoolingResultIterator is used
> ------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1396
> URL: https://issues.apache.org/jira/browse/PHOENIX-1396
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.0.0
> Reporter: Jeffrey Zhong
> Attachments: PHOENIX-1396.patch
>
>
> In SpoolingResultIterator.java, we have following code:
> {code}
> tempFile = File.createTempFile("ResultSpooler",".bin", new File(spoolDirectory));
> DeferredFileOutputStream spoolTo = new DeferredFileOutputStream(size, tempFile) {
> {code}
> Basically we pre-create spill file even we don't reach memory threshold and later we delete the same file if it's not needed in finally block. We can remove these unnecessary file creation & deletion altogether.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)