You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 18:44:37 UTC
[GitHub] [airflow] potiuk opened a new pull request #20817: Add Context stub to Airflow packages
potiuk opened a new pull request #20817:
URL: https://github.com/apache/airflow/pull/20817
We agreed that context.pyi is useful to be included in the
airflow package as it will help our users with autocomplete and
verification of the custom operators.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20817: Add Context stub to Airflow packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20817:
URL: https://github.com/apache/airflow/pull/20817#issuecomment-1010518606
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SamWheating commented on pull request #20817: Add Context stub to Airflow packages
Posted by GitBox <gi...@apache.org>.
SamWheating commented on pull request #20817:
URL: https://github.com/apache/airflow/pull/20817#issuecomment-1010483100
> The context.pyi file itself is not included in this PR?
@ferruzzi The `context.pyi` file already exists ([here](https://github.com/apache/airflow/blob/main/airflow/utils/context.pyi)) this PR just updates the package specification so that these files are included in the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #20817: Add Context stub to Airflow packages
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #20817:
URL: https://github.com/apache/airflow/pull/20817#issuecomment-1010436134
The `context.pyi` file itself is not included in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20817: Add Context stub to Airflow packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20817:
URL: https://github.com/apache/airflow/pull/20817#issuecomment-1010257274
```
[jarek@penguini:~/code/airflow] add-context-stub-to-airflow-package+ 2 ± tar -tvzf dist/apache-airflow-2.3.0.dev0.tar.gz apache-airflow-2.3.0.dev0/ | grep pyi
-rw-r--r-- root/root 3481 2022-01-05 21:40 apache-airflow-2.3.0.dev0/airflow/utils/context.pyi
[jarek@penguini:~/code/airflow] add-context-stub-to-airflow-package+ ± unzip -t dist/apache_airflow-2.3.0.dev0-py3-none-any.whl | grep pyi
testing: airflow/utils/context.pyi OK
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20817: Add Context stub to Airflow packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20817:
URL: https://github.com/apache/airflow/pull/20817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org