You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "ChiaHung Lin (JIRA)" <ji...@apache.org> on 2010/12/31 13:19:45 UTC

[jira] Created: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Modify MniCluster so that developers can benefit when testing using Junit
-------------------------------------------------------------------------

                 Key: HAMA-346
                 URL: https://issues.apache.org/jira/browse/HAMA-346
             Project: Hama
          Issue Type: Improvement
          Components: test 
         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
            Reporter: ChiaHung Lin


The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by Chia-Hung Lin <cl...@googlemail.com>.
My bad. Thank you for help me correct it.

2011/1/13 Edward J. Yoon <ed...@apache.org>:
> Just FYI,
>
> In your patch, there was a simple bug, a kind of Type Mismatch Error.
>
> So, I've changed
>
> +            if(jip.getStatus().equals(JobStatus.SUCCEEDED)){
>
> to
>
> +          if (jip.getStatus().getRunState() == JobStatus.SUCCEEDED) {
>
>
> On Thu, Jan 13, 2011 at 1:22 PM, ChiaHung Lin (JIRA) <ji...@apache.org> wrote:
>>
>>    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981126#action_12981126 ]
>>
>> ChiaHung Lin commented on HAMA-346:
>> -----------------------------------
>>
>> I test the newly updated source checked out from svn, and it works well. Thanks for help arrange this.
>>
>>> Modify MniCluster so that developers can benefit when testing using Junit
>>> -------------------------------------------------------------------------
>>>
>>>                 Key: HAMA-346
>>>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>>>             Project: Hama
>>>          Issue Type: Improvement
>>>          Components: test
>>>    Affects Versions: 0.2.0
>>>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x
>>>            Reporter: ChiaHung Lin
>>>            Assignee: ChiaHung Lin
>>>             Fix For: 0.2.0
>>>
>>>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>>>
>>>
>>> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
>
> --
> Best Regards, Edward J. Yoon
> http://blog.udanax.org
> http://twitter.com/eddieyoon
>

Re: [jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon" <ed...@apache.org>.
Just FYI,

In your patch, there was a simple bug, a kind of Type Mismatch Error.

So, I've changed

+            if(jip.getStatus().equals(JobStatus.SUCCEEDED)){

to

+          if (jip.getStatus().getRunState() == JobStatus.SUCCEEDED) {


On Thu, Jan 13, 2011 at 1:22 PM, ChiaHung Lin (JIRA) <ji...@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981126#action_12981126 ]
>
> ChiaHung Lin commented on HAMA-346:
> -----------------------------------
>
> I test the newly updated source checked out from svn, and it works well. Thanks for help arrange this.
>
>> Modify MniCluster so that developers can benefit when testing using Junit
>> -------------------------------------------------------------------------
>>
>>                 Key: HAMA-346
>>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>>             Project: Hama
>>          Issue Type: Improvement
>>          Components: test
>>    Affects Versions: 0.2.0
>>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x
>>            Reporter: ChiaHung Lin
>>            Assignee: ChiaHung Lin
>>             Fix For: 0.2.0
>>
>>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>>
>>
>> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>



-- 
Best Regards, Edward J. Yoon
http://blog.udanax.org
http://twitter.com/eddieyoon

Re: [jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by Filipe David Manana <fd...@apache.org>.
Yes, both TCP and UDP ports are 16 bits unsigned integers :)

2011/1/10 Edward J. Yoon <ed...@udanax.org>:
> Haha, Thanks :D
>
> 나의 iPhone에서 보냄
>
> 2011. 1. 10. 오후 9:36 Filipe David Manana <fd...@apache.org> 작성:
>
>> On Mon, Jan 10, 2011 at 12:07 PM, Edward J. Yoon (JIRA) <ji...@apache.org> wrote:
>>>
>>>    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979559#action_12979559 ]
>>>
>>> Edward J. Yoon commented on HAMA-346:
>>> -------------------------------------
>>>
>>> Patch looks very cool! FIFO scheduler and Unit test are also great.
>>>
>>> BTW, in my test-bed (10 nodes cluster), some nodes (Gentoo server) throws below exception message "port out of range:71000".
>>>
>>> "7100" is OK :/ Do you know why?
>>
>> Edward, 71 000 is outside the port range (1 - 65535) :)
>>
>>>
>>> {code}
>>> 11/01/10 20:47:56 INFO zookeeper.ClientCnxn: Session establishment complete on server slave.udanax.org/192.168.123.198:21810, sessionid = 0x12d6fc542730001, negotiated timeout = 6000
>>> Exception in thread "regionservernull" java.lang.IllegalArgumentException: port out of range:71000
>>>        at java.net.InetSocketAddress.<init>(InetSocketAddress.java:118)
>>>        at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:247)
>>>        at org.apache.hadoop.ipc.Server.<init>(Server.java:1026)
>>>        at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:488)
>>>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:450)
>>>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:441)
>>>        at org.apache.hama.bsp.GroomServer.initialize(GroomServer.java:150)
>>>        at org.apache.hama.bsp.GroomServer.run(GroomServer.java:420)
>>>        at java.lang.Thread.run(Thread.java:619)
>>> 11/01/10 20:47:56 INFO hama.GroomServerRunner: SHUTDOWN_MSG:
>>> {code}
>>>
>>>> Modify MniCluster so that developers can benefit when testing using Junit
>>>> -------------------------------------------------------------------------
>>>>
>>>>                 Key: HAMA-346
>>>>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>>>>             Project: Hama
>>>>          Issue Type: Improvement
>>>>          Components: test
>>>>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x
>>>>            Reporter: ChiaHung Lin
>>>>         Attachments: HAMA-346.patch, HAMA-346.patch
>>>>
>>>>
>>>> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>>
>>
>> --
>> Filipe David Manana,
>> fdmanana@gmail.com, fdmanana@apache.org
>>
>> "Reasonable men adapt themselves to the world.
>>  Unreasonable men adapt the world to themselves.
>>  That's why all progress depends on unreasonable men."
>



-- 
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

Re: [jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon" <ed...@udanax.org>.
Haha, Thanks :D

나의 iPhone에서 보냄

2011. 1. 10. 오후 9:36 Filipe David Manana <fd...@apache.org> 작성:

> On Mon, Jan 10, 2011 at 12:07 PM, Edward J. Yoon (JIRA) <ji...@apache.org> wrote:
>> 
>>    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979559#action_12979559 ]
>> 
>> Edward J. Yoon commented on HAMA-346:
>> -------------------------------------
>> 
>> Patch looks very cool! FIFO scheduler and Unit test are also great.
>> 
>> BTW, in my test-bed (10 nodes cluster), some nodes (Gentoo server) throws below exception message "port out of range:71000".
>> 
>> "7100" is OK :/ Do you know why?
> 
> Edward, 71 000 is outside the port range (1 - 65535) :)
> 
>> 
>> {code}
>> 11/01/10 20:47:56 INFO zookeeper.ClientCnxn: Session establishment complete on server slave.udanax.org/192.168.123.198:21810, sessionid = 0x12d6fc542730001, negotiated timeout = 6000
>> Exception in thread "regionservernull" java.lang.IllegalArgumentException: port out of range:71000
>>        at java.net.InetSocketAddress.<init>(InetSocketAddress.java:118)
>>        at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:247)
>>        at org.apache.hadoop.ipc.Server.<init>(Server.java:1026)
>>        at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:488)
>>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:450)
>>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:441)
>>        at org.apache.hama.bsp.GroomServer.initialize(GroomServer.java:150)
>>        at org.apache.hama.bsp.GroomServer.run(GroomServer.java:420)
>>        at java.lang.Thread.run(Thread.java:619)
>> 11/01/10 20:47:56 INFO hama.GroomServerRunner: SHUTDOWN_MSG:
>> {code}
>> 
>>> Modify MniCluster so that developers can benefit when testing using Junit
>>> -------------------------------------------------------------------------
>>> 
>>>                 Key: HAMA-346
>>>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>>>             Project: Hama
>>>          Issue Type: Improvement
>>>          Components: test
>>>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x
>>>            Reporter: ChiaHung Lin
>>>         Attachments: HAMA-346.patch, HAMA-346.patch
>>> 
>>> 
>>> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.
>> 
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>> 
>> 
> 
> 
> 
> -- 
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
> 
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."

Re: [jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by Filipe David Manana <fd...@apache.org>.
On Mon, Jan 10, 2011 at 12:07 PM, Edward J. Yoon (JIRA) <ji...@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979559#action_12979559 ]
>
> Edward J. Yoon commented on HAMA-346:
> -------------------------------------
>
> Patch looks very cool! FIFO scheduler and Unit test are also great.
>
> BTW, in my test-bed (10 nodes cluster), some nodes (Gentoo server) throws below exception message "port out of range:71000".
>
> "7100" is OK :/ Do you know why?

Edward, 71 000 is outside the port range (1 - 65535) :)

>
> {code}
> 11/01/10 20:47:56 INFO zookeeper.ClientCnxn: Session establishment complete on server slave.udanax.org/192.168.123.198:21810, sessionid = 0x12d6fc542730001, negotiated timeout = 6000
> Exception in thread "regionservernull" java.lang.IllegalArgumentException: port out of range:71000
>        at java.net.InetSocketAddress.<init>(InetSocketAddress.java:118)
>        at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:247)
>        at org.apache.hadoop.ipc.Server.<init>(Server.java:1026)
>        at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:488)
>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:450)
>        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:441)
>        at org.apache.hama.bsp.GroomServer.initialize(GroomServer.java:150)
>        at org.apache.hama.bsp.GroomServer.run(GroomServer.java:420)
>        at java.lang.Thread.run(Thread.java:619)
> 11/01/10 20:47:56 INFO hama.GroomServerRunner: SHUTDOWN_MSG:
> {code}
>
>> Modify MniCluster so that developers can benefit when testing using Junit
>> -------------------------------------------------------------------------
>>
>>                 Key: HAMA-346
>>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>>             Project: Hama
>>          Issue Type: Improvement
>>          Components: test
>>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x
>>            Reporter: ChiaHung Lin
>>         Attachments: HAMA-346.patch, HAMA-346.patch
>>
>>
>> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>



-- 
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

[jira] Reopened: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon reopened HAMA-346:
---------------------------------


See https://hudson.apache.org/hudson/job/Hama-Nightly/81/console

This unit test fails sometimes. Let's fix again.

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977772#action_12977772 ] 

ChiaHung Lin commented on HAMA-346:
-----------------------------------

I think refactoring issue may take some time to finish. I will try to come up with patches next week, including refactored BSPMaster and GroomServer, so   the patches can get reviewed. 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981126#action_12981126 ] 

ChiaHung Lin commented on HAMA-346:
-----------------------------------

I test the newly updated source checked out from svn, and it works well. Thanks for help arrange this. 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977017#action_12977017 ] 

Edward J. Yoon commented on HAMA-346:
-------------------------------------

BTW, how much time will you need for this and refactoring issues?

If you can fix these issues shortly, I'd like to commit to the TRUNK (hama-0.2.0). 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-346:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this. Thanks ChiaHung!

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980078#action_12980078 ] 

Hudson commented on HAMA-346:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12467965/HAMA-346.patch
against trunk revision 1050275.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 22 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs -1.  The patch appears to introduce 9 new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/304/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/304/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/304/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/304/console

This message is automatically generated.

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaHung Lin updated HAMA-346:
------------------------------

    Attachment: HAMA-346.patch

A fix to the issue that a TaskStatus reported back from the GroomServer can not associate with any JobInProgress in BSPMaster, resulting in whichJob() returns null; thus failing to accomplish a job submission from the client. 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980101#action_12980101 ] 

Hudson commented on HAMA-346:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12468001/HAMA-346_removeWarnings.patch
against trunk revision 1050275.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 22 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs -1.  The patch appears to introduce 6 new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/305/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/305/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/305/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/305/console

This message is automatically generated.

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979565#action_12979565 ] 

Edward J. Yoon commented on HAMA-346:
-------------------------------------

Oh, tcp only has 65536 ports. Right?

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-346:
--------------------------------

        Fix Version/s: 0.2.0
             Assignee: ChiaHung Lin
    Affects Version/s: 0.2.0
               Status: Patch Available  (was: Open)

running patch through hudson

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979559#action_12979559 ] 

Edward J. Yoon commented on HAMA-346:
-------------------------------------

Patch looks very cool! FIFO scheduler and Unit test are also great.

BTW, in my test-bed (10 nodes cluster), some nodes (Gentoo server) throws below exception message "port out of range:71000". 

"7100" is OK :/ Do you know why?

{code}
11/01/10 20:47:56 INFO zookeeper.ClientCnxn: Session establishment complete on server slave.udanax.org/192.168.123.198:21810, sessionid = 0x12d6fc542730001, negotiated timeout = 6000
Exception in thread "regionservernull" java.lang.IllegalArgumentException: port out of range:71000
	at java.net.InetSocketAddress.<init>(InetSocketAddress.java:118)
	at org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:247)
	at org.apache.hadoop.ipc.Server.<init>(Server.java:1026)
	at org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:488)
	at org.apache.hadoop.ipc.RPC.getServer(RPC.java:450)
	at org.apache.hadoop.ipc.RPC.getServer(RPC.java:441)
	at org.apache.hama.bsp.GroomServer.initialize(GroomServer.java:150)
	at org.apache.hama.bsp.GroomServer.run(GroomServer.java:420)
	at java.lang.Thread.run(Thread.java:619)
11/01/10 20:47:56 INFO hama.GroomServerRunner: SHUTDOWN_MSG: 
{code}

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-346:
--------------------------------

    Attachment: HAMA-346_removeWarnings.patch

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaHung Lin updated HAMA-346:
------------------------------

    Attachment: HAMA-346.patch

The attached patch contains the update for MiniBSPCluster and the refactoring of BSPMaster and GromoServer. 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon resolved HAMA-346.
---------------------------------

    Resolution: Fixed

I just committed this, Thanks ChiaHung!

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>    Affects Versions: 0.2.0
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>            Assignee: ChiaHung Lin
>             Fix For: 0.2.0
>
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346.patch, HAMA-346_removeWarnings.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaHung Lin updated HAMA-346:
------------------------------

    Attachment: HAMA-346.patch

Sorry typo. 

I update the patch file, which should solve this problem. 



> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch, HAMA-346.patch, HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "ChiaHung Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaHung Lin updated HAMA-346:
------------------------------

    Attachment: HAMA-346.patch

This patch is required because currently when working on refactoring communication between BSPMaster and GroomServer, the default testing does not launch any master/ worker servers, resulting in the modified BSPMaster/ GroomServer can not be unit tested. 

The patch has been applied on the unit testing BSPMaster/ GroomServer, which is underway but not yet finished. But it may require more refinement; therefore, I appreciate any commentary. 

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-346) Modify MniCluster so that developers can benefit when testing using Junit

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976700#action_12976700 ] 

Edward J. Yoon commented on HAMA-346:
-------------------------------------

+1

> Modify MniCluster so that developers can benefit when testing using Junit
> -------------------------------------------------------------------------
>
>                 Key: HAMA-346
>                 URL: https://issues.apache.org/jira/browse/HAMA-346
>             Project: Hama
>          Issue Type: Improvement
>          Components: test 
>         Environment: Debian squeeze (kernel 2.6.3x) / JDK 1.6.x 
>            Reporter: ChiaHung Lin
>         Attachments: HAMA-346.patch
>
>
> The current junit test enviornment only provides default MiniCluster, which does not launch any BSPMaster and GroomServer. Therefore, this patch is provided for future junit testing when cluster environment is needed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.