[GitHub] [tvm] vinx13 commented on a diff in pull request #13383: [MetaSchedule] Add `from-target` Defaults for LLVM VNNI Targets

[GitBox <gi...@apache.org>]

vinx13 commented on code in PR #13383:
URL: https://github.com/apache/tvm/pull/13383#discussion_r1022205693


##########
src/meta_schedule/schedule_rule/schedule_rule.cc:
##########
@@ -85,6 +85,39 @@ Array<ScheduleRule> ScheduleRule::DefaultLLVM() {
   };
 }
 
+Array<ScheduleRule> ScheduleRule::DefaultVNNI() {
+  return {
+      ScheduleRule::AutoInline(
+          /*into_producer=*/false,
+          /*into_consumer=*/true,
+          /*inline_const_tensor=*/true,
+          /*disallow_if_then_else=*/true,
+          /*require_injective=*/true,
+          /*require_ordered=*/true,
+          /*disallow_op=*/Array<String>{"tir.exp"}),
+      ScheduleRule::AddRFactor(
+          /*max_jobs_per_core=*/16,
+          /*max_innermost_factor=*/Integer(64)),
+      ScheduleRule::MultiLevelTilingWithIntrin(

Review Comment:
   need to add `MultiLevelTiling` (with the config in default llvm) as a fallback when tensorization is not applicable 



##########
src/meta_schedule/schedule_rule/schedule_rule.cc:
##########
@@ -85,6 +85,39 @@ Array<ScheduleRule> ScheduleRule::DefaultLLVM() {
   };
 }
 
+Array<ScheduleRule> ScheduleRule::DefaultVNNI() {
+  return {
+      ScheduleRule::AutoInline(

Review Comment:
   We recently added new schedule rules `ApplyCustomRule` and `InlineConstantScalars` for llvm, let's also add them here for consistency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org