You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/09 06:42:49 UTC

[GitHub] [arrow] terencehonles commented on a change in pull request #8916: ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

terencehonles commented on a change in pull request #8916:
URL: https://github.com/apache/arrow/pull/8916#discussion_r554300596



##########
File path: dev/tasks/python-wheels/win-build.bat
##########
@@ -22,11 +22,19 @@
 
 @rem --file=arrow\ci\conda_env_gandiva.yml ^
 
-@rem create conda environment for compiling
 @rem FIXME: Update to numpy 1.16.6
+SET NUMPY_VERSION=1.16.5
+SET VS_VERSION=
+if %PYTHON_VERSION% == 3.6 (
+    SET VS_VERSION="<14.16"

Review comment:
       That's what I had here https://github.com/ursa-labs/crossbow/runs/1672510076 and it looked like it was treating it as interpolation. I'm not sure if it's not liking the multiline or the `else if`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org