You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2018/08/29 00:05:48 UTC

[incubator-superset] branch master updated: Disable input when IS (NOT) NULL selected in filters (#5766)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 48d220c  Disable input when IS (NOT) NULL selected in filters (#5766)
48d220c is described below

commit 48d220c03a484d9d4c9cde705128850b5d04b1b7
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Tue Aug 28 17:05:44 2018 -0700

    Disable input when IS (NOT) NULL selected in filters (#5766)
---
 .../src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
index 94535cd..6c670b6 100644
--- a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
+++ b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
@@ -283,6 +283,7 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon
                 value={adhocFilter.comparator || ''}
                 className="form-control input-sm"
                 placeholder={t('Filter value')}
+                disabled={adhocFilter.operator === 'IS NOT NULL' || adhocFilter.operator === 'IS NULL'}
               />
           }
         </FormGroup>