You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/01 02:54:00 UTC
[jira] [Commented] (KAFKA-7460) Connect Values converter uses
incorrect date format string
[ https://issues.apache.org/jira/browse/KAFKA-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633583#comment-16633583 ]
ASF GitHub Bot commented on KAFKA-7460:
---------------------------------------
ewencp closed pull request #5718: KAFKA-7460: Fix Connect Values converter date format pattern
URL: https://github.com/apache/kafka/pull/5718
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java b/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java
index ceb176858d7..c9447450f02 100644
--- a/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java
+++ b/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java
@@ -70,7 +70,7 @@
private static final String FALSE_LITERAL = Boolean.TRUE.toString();
private static final long MILLIS_PER_DAY = 24 * 60 * 60 * 1000;
private static final String NULL_VALUE = "null";
- private static final String ISO_8601_DATE_FORMAT_PATTERN = "YYYY-MM-DD";
+ private static final String ISO_8601_DATE_FORMAT_PATTERN = "yyyy-MM-dd";
private static final String ISO_8601_TIME_FORMAT_PATTERN = "HH:mm:ss.SSS'Z'";
private static final String ISO_8601_TIMESTAMP_FORMAT_PATTERN = ISO_8601_DATE_FORMAT_PATTERN + "'T'" + ISO_8601_TIME_FORMAT_PATTERN;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Connect Values converter uses incorrect date format string
> ----------------------------------------------------------
>
> Key: KAFKA-7460
> URL: https://issues.apache.org/jira/browse/KAFKA-7460
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 1.1.0, 1.1.1, 2.0.0
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Priority: Blocker
> Fix For: 1.1.2, 2.0.1, 2.1.0
>
>
> Discovered in KAFKA-6684, the converter is using week date year (YYYY) instead of plain year (yyyy) and day in year (DD) instead of date in month (dd).
> Filing this so we have independent tracking of the issue since it was only tangentially related and discovered in that issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)