[GitHub] [samza] mynameborat commented on a change in pull request #1335: Optimizing startpoint manager to not make successive bootstrapMessage calls to coordinator-store

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1335: Optimizing startpoint manager to not make successive bootstrapMessage calls to coordinator-store
URL: https://github.com/apache/samza/pull/1335#discussion_r401354195
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/startpoint/StartpointManager.java
 ##########
 @@ -159,38 +160,63 @@ public void writeStartpoint(SystemStreamPartition ssp, TaskName taskName, Startp
    *         It is empty if it does not exist or if it is too stale.
    */
   public Optional<Startpoint> readStartpoint(SystemStreamPartition ssp) {
-    return readStartpoint(ssp, null);
+    return readStartpointMap(Collections.singletonMap(null, Collections.singleton(ssp)), false).get(null)
 
 Review comment:
   `null` as a key and `.get(null)` looks atypical and not readable on the go. It does require some context for someone to get the background on this.
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services