You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/05 13:23:04 UTC
[GitHub] [incubator-seatunnel] songjianet opened a new pull request, #2136: [Feat][UI] Add theme-related configuration.
songjianet opened a new pull request, #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
close [#2135](https://github.com/apache/incubator-seatunnel/issues/2135)
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie merged pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] songjianet commented on a diff in pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
songjianet commented on code in PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#discussion_r914337365
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -16,7 +16,9 @@
*/
import { getCurrentInstance, onMounted, onBeforeUnmount, watch } from 'vue'
+import { useThemeStore } from '@/store/theme'
import { throttle } from 'echarts'
+import { useI18n } from 'vue-i18n'
import type { Ref } from 'vue'
import type { ECharts } from 'echarts'
Review Comment:
I don't need it for the time being. I think it's possible to supplement the license before the release, like ds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#issuecomment-1176183336
cc @songjianet @Amy0104 It seems currently we do not need run all ci in `ui` change anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] songjianet commented on a diff in pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
songjianet commented on code in PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#discussion_r914337365
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -16,7 +16,9 @@
*/
import { getCurrentInstance, onMounted, onBeforeUnmount, watch } from 'vue'
+import { useThemeStore } from '@/store/theme'
import { throttle } from 'echarts'
+import { useI18n } from 'vue-i18n'
import type { Ref } from 'vue'
import type { ECharts } from 'echarts'
Review Comment:
I don't need it for the time being. I think it's possible to supplement the license before the release, like ds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#discussion_r914395569
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -16,7 +16,9 @@
*/
import { getCurrentInstance, onMounted, onBeforeUnmount, watch } from 'vue'
+import { useThemeStore } from '@/store/theme'
import { throttle } from 'echarts'
+import { useI18n } from 'vue-i18n'
import type { Ref } from 'vue'
import type { ECharts } from 'echarts'
Review Comment:
I would say no. don't say like DS, we are still in the incubator, I believe that any project will strictly require a license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Amy0104 commented on a diff in pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on code in PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#discussion_r914338911
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -42,6 +47,22 @@ function initChart<Opt extends ECBasicOption>(
chart && chart.resize()
}, 20)
+ watch(
+ () => themeStore.darkTheme,
+ () => {
+ chart?.dispose()
+ init()
+ }
Review Comment:
Why not put the chart.dipose() into the init function?
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -42,6 +47,22 @@ function initChart<Opt extends ECBasicOption>(
chart && chart.resize()
}, 20)
+ watch(
+ () => themeStore.darkTheme,
+ () => {
+ chart?.dispose()
+ init()
+ }
Review Comment:
Why not put the chart.dipose() into the init function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2136: [Feat][UI] Add theme-related configuration.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2136:
URL: https://github.com/apache/incubator-seatunnel/pull/2136#discussion_r914336906
##########
seatunnel-ui/src/components/chart/index.ts:
##########
@@ -16,7 +16,9 @@
*/
import { getCurrentInstance, onMounted, onBeforeUnmount, watch } from 'vue'
+import { useThemeStore } from '@/store/theme'
import { throttle } from 'echarts'
+import { useI18n } from 'vue-i18n'
import type { Ref } from 'vue'
import type { ECharts } from 'echarts'
Review Comment:
did we need add echarts license file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org