[GitHub] jmeter pull request #387: Add delegation for SPNEGO back to JMeter

[FSchumacher <gi...@git.apache.org>]

GitHub user FSchumacher opened a pull request:

    https://github.com/apache/jmeter/pull/387

    Add delegation for SPNEGO back to JMeter

    ## Description
    <!--- Provide a general summary of your changes in the Title above -->
    <!--- Describe your changes in detail here -->
    Newer httpclient versions (at least in the 4.x branch) have dropped the support for delegation of kerberos tickets over SPNEGO. This patch brings back the support to delegation back to JMeter.
    
    ## Motivation and Context
    Older versions of JMeter always tried to get forwardable tickets when using SPNEGO. As I need this functionality for a service, I would like to have the forwarding back. As the default forwarding could be seen critical from a security standpoint, the patch disables it by default. It can be enabled by a system property.
    <!--- Why is this change required? What problem does it solve? -->
    <!--- If it fixes an open issue, please link to the issue here. -->
    
    ## How Has This Been Tested?
    <!--- Please describe in detail how you tested your changes. -->
    <!--- Include details of your testing environment, tests ran to see how -->
    <!--- your change affects other areas of the code, etc. -->
    Tested it on a service that depends on delegation of tickets.
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Bug fix (non-breaking change which fixes an issue) (At least I see this as a regression)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FSchumacher/jmeter delegate-krb

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit 94b369b64f931b75564e4df47231754602639972
Author: Felix Schumacher <fe...@...>
Date:   2018-06-07T17:54:03Z

    Add delegation for SPNEGO back to JMeter

----


---

[GitHub] jmeter issue #387: Add delegation for SPNEGO back to JMeter

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/387
  
    Thanks Felix


---

[GitHub] jmeter pull request #387: Add delegation for SPNEGO back to JMeter

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/387


---

[GitHub] jmeter issue #387: Add delegation for SPNEGO back to JMeter

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/387
  
    Thanks for PR.
    Just wondering, why do we use httpcomponents package ?
    
    - org.apache.http.impl.auth.DelegatingKerberosScheme
    - org.apache.http.impl.auth.DelegatingSPNegoScheme
    
    Thanks


---

[GitHub] jmeter issue #387: Add delegation for SPNEGO back to JMeter

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/387
  
    Hi Felix,
    Did you have time to check the changes are working ? 
    If yes, +1 for committing it.


---

[GitHub] jmeter issue #387: Add delegation for SPNEGO back to JMeter

[FSchumacher <gi...@git.apache.org>]

Github user FSchumacher commented on the issue:

    https://github.com/apache/jmeter/pull/387
  
    I thought I hat to overwrite the method `createGSSContext`, which is only possible on a subclass in the same package. I changed it now explicitly to call another method and placed the classes in JMeter's package namespace. Will check on Monday, if it is still working.


---