You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/03/14 21:31:45 UTC
[GitHub] cordova-cli pull request: CB-6267 Windows8. Apply BackgroundColor ...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/142
CB-6267 Windows8. Apply BackgroundColor from config.xml
https://issues.apache.org/jira/browse/CB-6267
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/cordova-cli CB-6267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 56a7893362421b49e782521698057ae40d7c8d3a
Author: sgrebnov <se...@gmail.com>
Date: 2014-03-14T20:30:35Z
CB-6267 Windows8. Apply BackgroundColor from config.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6267 Windows8. Apply BackgroundColor ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6267 Windows8. Apply BackgroundColor ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/142#issuecomment-38505972
This is being merged, however, I believe this property can be changed after 'create' has been called.
There should be a platform script that ensures any preferences in config.xml are processed at build time, OR there should be a runtime check. Either way, this would need to be fixed in the windows8 project, and not the cli.
Reposting this info to JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---