You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Anne Yu <an...@cloudera.com> on 2016/02/04 22:13:52 UTC
Review Request 43222: Improve tests clean up logic to catch exceptions
caused by deleting objects not created by sentry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43222/
-----------------------------------------------------------
Review request for sentry.
Bugs: sentry-1050
https://issues.apache.org/jira/browse/sentry-1050
Repository: sentry
Description
-------
e2e keeps having failures because when clean up test objects, tests can't delete databases and tables created by other processes than sentry; both these objects and test objects' names are not consistently sticking to one rule; so the current way to fix it is to catch these exceptions. They are not happening in the tests, just in the aftertest cleanup.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 052c102d6d0b63b1b0eeb7d770480ac9bb88a613
Diff: https://reviews.apache.org/r/43222/diff/
Testing
-------
passed jenkin's pre-commit.
Thanks,
Anne Yu
Re: Review Request 43222: Improve tests clean up logic to catch
exceptions caused by deleting objects not created by sentry
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43222/#review117927
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Feb. 4, 2016, 9:13 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43222/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 9:13 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: sentry-1050
> https://issues.apache.org/jira/browse/sentry-1050
>
>
> Repository: sentry
>
>
> Description
> -------
>
> e2e keeps having failures because when clean up test objects, tests can't delete databases and tables created by other processes than sentry; both these objects and test objects' names are not consistently sticking to one rule; so the current way to fix it is to catch these exceptions. They are not happening in the tests, just in the aftertest cleanup.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 052c102d6d0b63b1b0eeb7d770480ac9bb88a613
>
> Diff: https://reviews.apache.org/r/43222/diff/
>
>
> Testing
> -------
>
> passed jenkin's pre-commit.
>
>
> Thanks,
>
> Anne Yu
>
>