You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "jiaoqingbo (via GitHub)" <gi...@apache.org> on 2023/05/16 03:09:11 UTC
[GitHub] [ranger] jiaoqingbo opened a new pull request, #257: RANGER-4239: Upgrade Trino version to 410
jiaoqingbo opened a new pull request, #257:
URL: https://github.com/apache/ranger/pull/257
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. RANGER-XXXX: Fix a typo in YYY))
upgrade trino version from 377 to 410
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] A-little-bit-of-data commented on pull request #257: RANGER-4239: Upgrade Trino version to 410
Posted by "A-little-bit-of-data (via GitHub)" <gi...@apache.org>.
A-little-bit-of-data commented on PR #257:
URL: https://github.com/apache/ranger/pull/257#issuecomment-1690050277
Hello, I compiled according to the modified source code you provided above, and I kept reporting errors.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-trino-plugin: Compilation failure: Compilation failure:
[ERROR] Picked up JAVA_TOOL_OPTIONS: -Xmx3489m
[ERROR] /workspace/ranger/plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:[21,29] error: cannot access CatalogSchemaName
[ERROR] bad class file: /workspace/m2-repository/io/trino/trino-spi/424/trino-spi-424.jar(/io/trino/spi/connector/CatalogSchemaName.class)
[ERROR] class file has wrong version 61.0, should be 55.0
I finally changed the jdk version and reported an error. I would like to ask if you have compiled successfully according to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] Yiutto commented on pull request #257: RANGER-4239: Upgrade Trino version to 410
Posted by "Yiutto (via GitHub)" <gi...@apache.org>.
Yiutto commented on PR #257:
URL: https://github.com/apache/ranger/pull/257#issuecomment-1653117623
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-trino-plugin: Compilation failure: Compilation failure:
[ERROR] /home/trino/ranger-release-ranger-2.3.0/plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:[159,2] error: method does not override or implement a method from a supertype
[ERROR] /home/trino/ranger-release-ranger-2.3.0/plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:[350,2] error: method does not override or implement a method from a supertype
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-trino-plugin: Compilation failure
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
trino-420 (jdk17),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] jiaoqingbo closed pull request #257: RANGER-4239: Upgrade Trino version to 410
Posted by "jiaoqingbo (via GitHub)" <gi...@apache.org>.
jiaoqingbo closed pull request #257: RANGER-4239: Upgrade Trino version to 410
URL: https://github.com/apache/ranger/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ranger] datahub-karrot commented on a diff in pull request #257: RANGER-4239: Upgrade Trino version to 410
Posted by "datahub-karrot (via GitHub)" <gi...@apache.org>.
datahub-karrot commented on code in PR #257:
URL: https://github.com/apache/ranger/pull/257#discussion_r1227647596
##########
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:
##########
@@ -517,18 +518,6 @@ public void checkCanShowRoleGrants(SystemSecurityContext context) {
}
}
- @Override
- public Optional<ViewExpression> getRowFilter(SystemSecurityContext context, CatalogSchemaTableName tableName) {
Review Comment:
Hi, @jiaoqingbo I have a question. Why did you remove this function to make ranger plugin work w/ Trino 410+?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org