You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/04/20 09:06:30 UTC

[GitHub] [pinot] codecov-commenter commented on pull request #10653: Remove actually unsupported config that selectively enable nullable columns

codecov-commenter commented on PR #10653:
URL: https://github.com/apache/pinot/pull/10653#issuecomment-1515983152

   ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10653](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (708b787) into [master](https://codecov.io/gh/apache/pinot/commit/2d6a38c0a13aecb055ea1d81efdc4cc8dfba197a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d6a38c) will **decrease** coverage by `35.41%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #10653       +/-   ##
   =============================================
   - Coverage     70.33%   34.93%   -35.41%     
   + Complexity     6499      462     -6037     
   =============================================
     Files          2108     2108               
     Lines        113535   113541        +6     
     Branches      17117    17117               
   =============================================
   - Hits          79859    39669    -40190     
   - Misses        28083    70413    +42330     
   + Partials       5593     3459     -2134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `24.50% <0.00%> (+<0.01%)` | :arrow_up: |
   | integration2 | `23.96% <0.00%> (-0.18%)` | :arrow_down: |
   | unittests1 | `?` | |
   | unittests2 | `13.87% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...creator/impl/nullvalue/NullValueVectorCreator.java](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9udWxsdmFsdWUvTnVsbFZhbHVlVmVjdG9yQ3JlYXRvci5qYXZh) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...al/segment/index/nullvalue/NullValueIndexType.java](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2luZGV4L251bGx2YWx1ZS9OdWxsVmFsdWVJbmRleFR5cGUuamF2YQ==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
   | [...che/pinot/segment/spi/index/AbstractIndexType.java](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L0Fic3RyYWN0SW5kZXhUeXBlLmphdmE=) | `0.00% <0.00%> (-83.34%)` | :arrow_down: |
   | [...ment/spi/index/MergedColumnConfigDeserializer.java](https://codecov.io/gh/apache/pinot/pull/10653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L01lcmdlZENvbHVtbkNvbmZpZ0Rlc2VyaWFsaXplci5qYXZh) | `0.00% <0.00%> (-75.87%)` | :arrow_down: |
   
   ... and [1212 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10653/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org