You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/21 16:07:37 UTC
[GitHub] [hudi] codope opened a new pull request, #5387: [HUDI-3940] Fix retry count increment in lock manager
codope opened a new pull request, #5387:
URL: https://github.com/apache/hudi/pull/5387
## What is the purpose of the pull request
Retry count in lockmanager should be incremented even when it attempts to acquire lock but fails.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105662747
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
}, {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206",
"triggerID" : "1105650714",
"triggerType" : "MANUAL"
}, {
"hash" : "64f00fe3cf3081f0e4db847c52caeb96fc8e005a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8207",
"triggerID" : "64f00fe3cf3081f0e4db847c52caeb96fc8e005a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206)
* 64f00fe3cf3081f0e4db847c52caeb96fc8e005a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8207)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105653326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
}, {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206",
"triggerID" : "1105650714",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105426567
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5387:
URL: https://github.com/apache/hudi/pull/5387#discussion_r855360523
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -70,11 +70,12 @@ public void lock() {
}
LOG.info("Retrying to acquire lock...");
Thread.sleep(maxWaitTimeInMs);
- retryCount++;
} catch (HoodieLockException | InterruptedException e) {
if (retryCount >= maxRetries) {
throw new HoodieLockException("Unable to acquire lock, lock object ", e);
}
+ } finally {
+ retryCount++;
Review Comment:
No need to address in this PR, but it's better to increment the count _before_ the attempt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105659235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
}, {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206",
"triggerID" : "1105650714",
"triggerType" : "MANUAL"
}, {
"hash" : "64f00fe3cf3081f0e4db847c52caeb96fc8e005a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64f00fe3cf3081f0e4db847c52caeb96fc8e005a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8206)
* 64f00fe3cf3081f0e4db847c52caeb96fc8e005a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105650714
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105430218
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5387:
URL: https://github.com/apache/hudi/pull/5387#issuecomment-1105631255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204",
"triggerID" : "75c587a72afceb48ec30a94239acabcd441ab0c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c587a72afceb48ec30a94239acabcd441ab0c8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8204)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #5387: [HUDI-3940] Fix retry count increment in lock manager
Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #5387:
URL: https://github.com/apache/hudi/pull/5387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org