You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/30 01:04:00 UTC
[jira] [Work logged] (KNOX-2467) Enable Jetty's X-Forwarded Header
Support
[ https://issues.apache.org/jira/browse/KNOX-2467?focusedWorklogId=506477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506477 ]
ASF GitHub Bot logged work on KNOX-2467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/20 01:03
Start Date: 30/Oct/20 01:03
Worklog Time Spent: 10m
Work Description: lmccay opened a new pull request #382:
URL: https://github.com/apache/knox/pull/382
Change-Id: Id0b80df21c39b8af2a50c3543a121387e516410a
(It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull request?
In order for HttpServletRequest.getRequestURL to reflect the actual URL used by the user when going through a loadbalancer, we need to enable the embedded Jetty server's support for X-Forwarded Headers.
This will be enabled by a gateway-site.xml config property to preserve backward compatibility and be enabled by default.
## How was this patch tested?
This was tested via updated and added unit tests and manual testing with curl and browser to insure that X-Forwarded Headers
properly drive the URLs for redirects and originalUrl creation within KnoxSSO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 506477)
Remaining Estimate: 0h
Time Spent: 10m
> Enable Jetty's X-Forwarded Header Support
> -----------------------------------------
>
> Key: KNOX-2467
> URL: https://issues.apache.org/jira/browse/KNOX-2467
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In order for HttpServletRequest.getRequestURL to reflect the actual URL used by the user when going through a loadbalancer, we need to enable the embedded Jetty server's support for X-Forwarded Headers.
> This will be enabled by a gateway-site.xml config property to preserve backward compatibility and be disabled by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)