You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Florian Weimer <fw...@deneb.enyo.de> on 2004/02/06 08:07:45 UTC
Bogus comment in subversion/libsvn_client/status.c
The comment directly contradicts the code. Looks like a cut'n'paste
error.
Index: subversion/libsvn_client/status.c
===================================================================
--- subversion/libsvn_client/status.c (revision 8550)
+++ subversion/libsvn_client/status.c (working copy)
@@ -101,8 +101,8 @@
sb.real_status_baton = status_baton;
sb.deleted_in_repos = FALSE;
- /* Need to lock the tree as even a non-recursive status requires the
- immediate directories to be locked. */
+ /* First checks do not require a repository lock. We will subsequently
+ reopen the repository with a lock. */
SVN_ERR (svn_wc_adm_probe_open (&adm_access, NULL, path,
FALSE, FALSE, pool));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bogus comment in subversion/libsvn_client/status.c
Posted by Julian Foad <ju...@btopenworld.com>.
Florian Weimer wrote:
> The comment directly contradicts the code. Looks like a cut'n'paste
> error.
I agree, but ...
> Index: subversion/libsvn_client/status.c
> ===================================================================
> --- subversion/libsvn_client/status.c (revision 8550)
> +++ subversion/libsvn_client/status.c (working copy)
> @@ -101,8 +101,8 @@
> sb.real_status_baton = status_baton;
> sb.deleted_in_repos = FALSE;
>
> - /* Need to lock the tree as even a non-recursive status requires the
> - immediate directories to be locked. */
> + /* First checks do not require a repository lock. We will subsequently
> + reopen the repository with a lock. */
> SVN_ERR (svn_wc_adm_probe_open (&adm_access, NULL, path,
> FALSE, FALSE, pool));
... the lock is on the working copy tree, not on the repository.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bogus comment in subversion/libsvn_client/status.c
Posted by kf...@collab.net.
Florian Weimer <fw...@deneb.enyo.de> writes:
> Corrected repost, this time with [PATCH] tag.
>
> * subversion/libsvn_client/status.c
> (svn_client_status): Change comment to match the code.
Thanks! Applied in r8582.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Bogus comment in subversion/libsvn_client/status.c
Posted by Florian Weimer <fw...@deneb.enyo.de>.
Corrected repost, this time with [PATCH] tag.
* subversion/libsvn_client/status.c
(svn_client_status): Change comment to match the code.
Index: subversion/libsvn_client/status.c
===================================================================
--- subversion/libsvn_client/status.c (revision 8578)
+++ subversion/libsvn_client/status.c (working copy)
@@ -101,8 +101,8 @@
sb.real_status_baton = status_baton;
sb.deleted_in_repos = FALSE;
- /* Need to lock the tree as even a non-recursive status requires the
- immediate directories to be locked. */
+ /* First checks do not require a lock on the working copy. We will
+ reopen the working copy with a lock below. */
SVN_ERR (svn_wc_adm_probe_open (&adm_access, NULL, path,
FALSE, FALSE, pool));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org