You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by ti...@apache.org on 2016/04/08 20:41:16 UTC
incubator-asterixdb git commit: reduce log output during tests
Repository: incubator-asterixdb
Updated Branches:
refs/heads/master c5c78e48e -> 18ba0337d
reduce log output during tests
Change-Id: Ia6a114e59505341e46f9cb50d3850190630b64d6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/773
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <bu...@gmail.com>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/commit/18ba0337
Tree: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/tree/18ba0337
Diff: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/diff/18ba0337
Branch: refs/heads/master
Commit: 18ba0337dc918b1fbbf85316c1146897378a13f3
Parents: c5c78e4
Author: Till Westmann <ti...@apache.org>
Authored: Thu Apr 7 15:20:39 2016 -0700
Committer: Till Westmann <ti...@apache.org>
Committed: Fri Apr 8 11:33:43 2016 -0700
----------------------------------------------------------------------
.../operators/FeedMetaComputeNodePushable.java | 12 ++++++++---
.../operators/FeedMetaStoreNodePushable.java | 22 ++++++++++++++------
.../external/classad/test/ClassAdUnitTest.java | 2 +-
3 files changed, 26 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18ba0337/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
index 210a94d..6c9ef8d 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java
@@ -206,15 +206,21 @@ public class FeedMetaComputeNodePushable extends AbstractUnaryInputUnaryOutputOp
inputSideHandler.setFinished(true);
}
coreOperator.close();
- System.out.println("CLOSED " + coreOperator + " STALLED ?" + stalled + " ENDED " + end);
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("CLOSED " + coreOperator + " STALLED ?" + stalled + " ENDED " + end);
+ }
} catch (InterruptedException e) {
throw new HyracksDataException(e);
} finally {
if (!stalled) {
deregister();
- System.out.println("DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ }
} else {
- System.out.println("NOT DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("NOT DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ }
}
inputSideHandler.close();
if (LOGGER.isLoggable(Level.INFO)) {
http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18ba0337/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
index 7150210..f11b948 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
@@ -191,12 +191,16 @@ public class FeedMetaStoreNodePushable extends AbstractUnaryInputUnaryOutputOper
@Override
public void close() throws HyracksDataException {
- System.out.println("CLOSE CALLED FOR " + this.feedRuntime.getRuntimeId());
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("CLOSE CALLED FOR " + this.feedRuntime.getRuntimeId());
+ }
boolean stalled = inputSideHandler.getMode().equals(Mode.STALL);
try {
if (!stalled) {
- System.out.println("SIGNALLING END OF DATA for " + this.feedRuntime.getRuntimeId() + " mode is "
- + inputSideHandler.getMode() + " WAITING ON " + coreOperator);
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("SIGNALLING END OF DATA for " + this.feedRuntime.getRuntimeId() + " mode is "
+ + inputSideHandler.getMode() + " WAITING ON " + coreOperator);
+ }
inputSideHandler.nextFrame(null); // signal end of data
while (!inputSideHandler.isFinished()) {
synchronized (coreOperator) {
@@ -206,7 +210,9 @@ public class FeedMetaStoreNodePushable extends AbstractUnaryInputUnaryOutputOper
coreOperator.wait();
}
}
- System.out.println("ABOUT TO CLOSE OPERATOR " + coreOperator);
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("ABOUT TO CLOSE OPERATOR " + coreOperator);
+ }
}
coreOperator.close();
} catch (Exception e) {
@@ -214,9 +220,13 @@ public class FeedMetaStoreNodePushable extends AbstractUnaryInputUnaryOutputOper
} finally {
if (!stalled) {
deregister();
- System.out.println("DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ }
} else {
- System.out.println("NOT DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ if (LOGGER.isLoggable(Level.FINE)) {
+ LOGGER.fine("NOT DEREGISTERING " + this.feedRuntime.getRuntimeId());
+ }
}
inputSideHandler.close();
if (LOGGER.isLoggable(Level.INFO)) {
http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18ba0337/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
index 32ce485..572460e 100644
--- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
+++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/ClassAdUnitTest.java
@@ -49,7 +49,7 @@ public class ClassAdUnitTest extends TestCase {
* Rigourous Test :-)
*/
public void test() {
- String[] args = { "", "-d", "-vv", "-all" };
+ String[] args = { "", "-d", "-all" };
try {
ClassAdUnitTester.test(args.length, args, new ClassAdObjectPool());
} catch (Throwable e) {